Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Request] Recipe Book like inventory button. #123

Open
murao-kun opened this issue Feb 1, 2023 · 4 comments
Open

[Request] Recipe Book like inventory button. #123

murao-kun opened this issue Feb 1, 2023 · 4 comments

Comments

@murao-kun
Copy link

Hello! That will sound a little bit strange, but I am making a modpack based on this mod exactly. I wished to have quests in my modpack but in the process o using questing mods, I realised that advancements ended up pointless.
Now I am scraping quests and wishing to use advancements instead, this mod helps a lot to make advancements screen looks more usable and comfortable.
So after all being said, I wish to have config option with button like Recipe Book instead of tab one and configurable X and Y values for that. That will help to make it in line with other modded buttons. Thank you!

@way2muchnoise
Copy link
Owner

There is already a setting that adds a recipe book like button with the setting addInventoryButton (default is false).

I can take a look at making the XY location configurable.

@murao-kun
Copy link
Author

Yeah, I seen that, but it is more like a tab, rather than button. Not the thing I am looking for. Still, thanks for considering!

@way2muchnoise
Copy link
Owner

Could you create a screenshot with some editing to show what you would like to see?

@murao-kun
Copy link
Author

murao-kun commented Feb 4, 2023

Not at PC right now, to create a screenshot with some editing, but I will reference vanilla recipe book button as an example of what I am talking about:
Screenshot_2023-02-05-02-40-26-775-edit_com android chrome
This suggestion implementation could be looking exactly like that, just being placed by default near vanilla recipe book button with offset to the right.
Most important details:

  • Should have two states, one being active (when you have your pointer on it), and another inactive.
  • Should have configurable offset by X and Y, that could be useful to pack devs (like me) and just regular players to move it in case of modded conflict.

That's it, most of mods implement their inventory buttons like that too. You could take Curios mod as an example of that. Or Waystone mod, if inventory button config option is enabled.
Feel free to ask me, if you need texture for that. I could make it, if you wish.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

2 participants