Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Consider supporting application/x-www-form-urlencoded as content type for webhook #166

Closed
ocean90 opened this issue May 13, 2019 · 0 comments · Fixed by #183
Closed

Consider supporting application/x-www-form-urlencoded as content type for webhook #166

ocean90 opened this issue May 13, 2019 · 0 comments · Fixed by #183
Assignees
Labels
[Component] API Concerns REST API Endpoints, e.g. for incoming webhooks [Type] Enhancement New functionality
Milestone

Comments

@ocean90
Copy link
Member

ocean90 commented May 13, 2019

Issue Overview
When using application/x-www-form-urlencoded and not application/json as the content type for the incoming webhook you get the message {"result":"Not the default branch"}.
I'd expect another message if the content type isn't supported at all or, maybe be better, actually supported.

To Reproduce
Steps to reproduce the behavior:

  1. Go to a GitHub project
  2. Change the content type of the webhook
  3. Scroll down to a previous delivery
  4. Click Redeliver and check the response tab

Expected behavior
An better error message or a successful import.

@ocean90 ocean90 added [Type] Enhancement New functionality [Component] API Concerns REST API Endpoints, e.g. for incoming webhooks labels May 13, 2019
@ocean90 ocean90 self-assigned this Jul 20, 2020
@ocean90 ocean90 added this to the 3.1.0 milestone Jul 20, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
[Component] API Concerns REST API Endpoints, e.g. for incoming webhooks [Type] Enhancement New functionality
Projects
None yet
1 participant