Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Repo name/URL to project matching is too greedy #187

Closed
ocean90 opened this issue Sep 29, 2020 · 0 comments · Fixed by #188
Closed

Repo name/URL to project matching is too greedy #187

ocean90 opened this issue Sep 29, 2020 · 0 comments · Fixed by #188
Labels
[Priority] High [Type] Bug Bugs and regressions in existing functionality
Milestone

Comments

@ocean90
Copy link
Member

ocean90 commented Sep 29, 2020

Issue Overview
If you have a GlotPress project with the path foo/foo-bar and push something to a repo name foo, Traduttore will update foo/foo-bar with the content of foo. Since the text domain won't match it actually deletes all originals.

To Reproduce
Steps to reproduce the behavior:

  1. Create a repo foo
  2. Create a repo foo-bar
  3. Set up a GlotPress project for foo-bar
  4. Push something to foo
  5. Notice that foo-bar has no strings anymore

Expected behavior
The repo should not match partially another repo/project.

@ocean90 ocean90 added [Type] Bug Bugs and regressions in existing functionality [Priority] High labels Sep 29, 2020
@ocean90 ocean90 added this to the 3.2.0 milestone Oct 2, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
[Priority] High [Type] Bug Bugs and regressions in existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant