Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

billing enforcer no longer prints any logs #2264

Closed
rndstr opened this issue Aug 27, 2018 · 3 comments
Closed

billing enforcer no longer prints any logs #2264

rndstr opened this issue Aug 27, 2018 · 3 comments
Labels
bug broken end user functionality; not working as the developers intended it component/billing

Comments

@rndstr
Copy link

rndstr commented Aug 27, 2018 •
edited
Loading

while investigating #2262 i realized there are no logs at all.
@rndstr rndstr added bug broken end user functionality; not working as the developers intended it component/billing labels Aug 27, 2018
@rndstr rndstr self-assigned this Aug 27, 2018
@rndstr
Copy link
Author

rndstr commented Aug 27, 2018 •
edited
Loading

service/billing-enforcer/job/enforce.go

Line 90 in 6162227

logger := user.LogWith(ctx, logging.Global())

and logging.Global() is a discard logger by default.

The new logging bridge was introduced in weaveworks/common#96
and merged into service at #2201

@rndstr
Copy link
Author

rndstr commented Aug 27, 2018

Fix at weaveworks/common#122

@rndstr rndstr mentioned this issue Aug 27, 2018
Closed
@rndstr rndstr mentioned this issue Sep 15, 2018
Closed
@rndstr
Copy link
Author

rndstr commented Sep 27, 2018

Fix for this has been brought in by #2306

@rndstr rndstr closed this as completed Sep 27, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug broken end user functionality; not working as the developers intended it component/billing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rndstr