Note
This information is for project peers and owners.
If a pull request has been approved and tests are passing, then you can merge it. Follow these steps to merge:
-
Make sure you should merge this pull request. In general, only merge pull requests you are already familiar with, either as an author or reviewer.
-
Make sure you should merge this pull request. Some changes—most notably, feature removals, tooling and policy changes, and schema changes—require an owner to merge. See the privileges and responsibilities matrix for more information.
-
Make sure there are no explicit blockers to merging. Blockers include:
- The pull request has the blocked label.
- A reviewer asked to re-review before merging or has requested changes that have not been addressed with a commit or comment.
- The author explicitly asked to delay merging.
- The author explicitly asked for review from all requested reviewers (the presumption is at least one but not all).
If a blocker no longer applies, remove the label or dismiss the stale review.
-
If the pull request might require a Semantic Versioning MAJOR or MINOR release, then add the minor version required or major version required label.
-
Click the Squash and merge button, then prepare the commit message.
Clean up the subject and message fields so they make sense as a single unit. For example, delete boilerplate messages about applying changes from code review. Often an imperative-noun subject, such as "Add example feature", is sufficient.
-
When you're ready to commit the changes, click Confirm squash and merge.