New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Features not following proper casing #1541

Open

npm1 opened this issue Aug 1, 2024 · 1 comment

npm1 commented Aug 1, 2024

It seems https://github.com/web-platform-dx/web-features/tree/main/features uses dash for each word (even if a word is a method composed of many words). So for example canvas-createconicgradient.yml. This translates to incorrectly named enums as in https://chromium-review.googlesource.com/c/chromium/src/+/5734512.

The text was updated successfully, but these errors were encountered:

Collaborator

foolip commented Aug 2, 2024

For the most part feature IDs separate each word, as in request-video-frame-callback. But you're right that we have some exceptions:

abortsignal-any
array-copywithin
array-findlast
array-fromasync
array-isarray
canvas-createconicgradient
canvas-roundrect
document-caretpositionfrompoint
growable-sharedarraybuffer
promise-allsettled
promise-withresolvers
resizable-arraybuffer
transferable-arraybuffer
url-canparse
urlpattern

How do we avoid doing this again (linting?) and should we change the existing identifiers?

cc @ddbeck @Elchi3 @captainbrosset

# for free to join this conversation on GitHub. Already have an account? # to comment