Ensure that BCD keys are only used once #1174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents a problem like in web-platform-dx#1164 from happening before we have a way to handle it.
ddbeck
approved these changes
Jun 3, 2024
| for (const bcdKey of data.compat_features) { | ||
| const otherKey = bcdToFeatureId.get(bcdKey); | ||
| if (otherKey) { | ||
| throw new Error(`BCD key ${bcdKey} is used in both ${otherKey} and ${key}, which creates ambiguity for some consumers. Please see https://github.com/web-platform-dx/web-features/issues/1173 and help us find a good solution to allow this.`); |
There was a problem hiding this comment.
I really like this message. 👍
There was a problem hiding this comment.
I'm glad you like it :) It's a bit weird to throw and error and still say that we'd like to allow it...
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents a problem like in #1164
from happening before we have a way to handle it.