Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add growable and resizable buffers #1242

Merged
merged 3 commits into from
Jun 25, 2024

Conversation

Elchi3
Copy link
Collaborator

@Elchi3 Elchi3 commented Jun 13, 2024

Is this how it works? :)

How do I create dist files?
npm run dist didn't create anything.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Jun 13, 2024
@captainbrosset
Copy link
Contributor

@Elchi3 I always give the name of the feature I want to refresh: npm run dist features/xyz.yaml

@Elchi3
Copy link
Collaborator Author

Elchi3 commented Jun 13, 2024

@captainbrosset ah great! Should have read that script more carefully. I guess I would expect all dists to be created/refreshed when not providing a feature name.

@Elchi3
Copy link
Collaborator Author

Elchi3 commented Jun 13, 2024

@ddbeck
Copy link
Collaborator

ddbeck commented Jun 13, 2024

@Elchi3 thank you! I understand the problem. I need split the labeling part of the workflow from the part that commits. I'll see if I can't fix this tomorrow.

@ddbeck ddbeck mentioned this pull request Jun 14, 2024
@ddbeck
Copy link
Collaborator

ddbeck commented Jun 14, 2024

I opened #1252 to fix the permissions issue.

features/growable-sharedarraybuffer.yml Outdated Show resolved Hide resolved
features/resizable-arraybuffer.yml Outdated Show resolved Hide resolved
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
@ddbeck ddbeck merged commit 7b1e0d1 into web-platform-dx:main Jun 25, 2024
3 checks passed
@Elchi3 Elchi3 deleted the growable-resizable-buffers branch June 25, 2024 16:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants