Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix throwing non-new Errors and literals #1338

Merged
merged 3 commits into from
Jul 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

# Opt-ins
!GOVERNANCE.md
!eslint.config.js

!/features/*.yml
/features/*.yml.dist
Expand Down
24 changes: 24 additions & 0 deletions eslint.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
import newWithError from "eslint-plugin-new-with-error";
import tseslint from "typescript-eslint";

export default tseslint.config(tseslint.configs.base, {
plugins: { newWithError },
rules: {
"no-throw-literal": "error",
"newWithError/new-with-error": "error",
},
files: ["**/*.ts"],
});

// TODO: do linting more comprehensively, something like:
// import eslint from "@eslint/js";
// export default tseslint.config(
// eslint.configs.recommendedTypeChecked,
// ...tseslint.configs.recommended,
// {
// plugins: { newWithError },
// rules: {
// "no-throw-literal": "error",
// "newWithError/new-with-error": "error",
// },
// );
Loading