Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add Canvas2D context #1500

Merged
merged 19 commits into from
Aug 19, 2024
Merged

Add Canvas2D context #1500

merged 19 commits into from
Aug 19, 2024

Conversation

petele
Copy link
Collaborator

@petele petele commented Jul 24, 2024 •
edited
Loading

Canvas 2D rendering context!

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Jul 24, 2024
@petele petele mentioned this pull request Jul 24, 2024
Open
petele
petele commented Jul 25, 2024
View reviewed changes
features/canvas-2d-image-smoothingquality.yml.dist Outdated
@@ -0,0 +1,13 @@
# Generated from: canvas-2d-image-smoothingquality.yml
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed no support in Firefox.

@petele
Copy link
Collaborator Author

petele commented Jul 25, 2024

One final comment - I did not set a compute_from on this, I think there should be one, but I don't feel like there's a good property to set it to. Open to suggestions here.

@petele petele marked this pull request as ready for review July 25, 2024 16:30
@petele petele requested review from ddbeck and foolip July 25, 2024 16:36
ddbeck
ddbeck reviewed Jul 29, 2024
View reviewed changes
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot to look over here—sorry for the volume of comments and number of questions. Thank you, @petele!

features/canvas-2d-context-alpha.yml Outdated Show resolved Hide resolved
features/canvas-2d-context-alpha.yml Outdated Show resolved Hide resolved
features/canvas-2d-context-colorspace.yml Outdated Show resolved Hide resolved
features/canvas-2d-context-colorspace.yml Outdated Show resolved Hide resolved
features/canvas-2d-context-desynchronized.yml Outdated Show resolved Hide resolved
features/canvas-2d-context.yml Outdated Show resolved Hide resolved
features/canvas-2d-filter.yml Outdated Show resolved Hide resolved
features/canvas-2d-font-rendering.yml Outdated Show resolved Hide resolved
features/canvas-2d-image-smoothingquality.yml Outdated Show resolved Hide resolved
features/canvas-2d.yml.dist Outdated Show resolved Hide resolved
@petele petele requested a review from ddbeck July 29, 2024 19:31
@petele
Copy link
Collaborator Author

petele commented Aug 13, 2024

@ddbeck - updated with discussed changes, ready for review.

ddbeck
ddbeck requested changes Aug 16, 2024
View reviewed changes
features/canvas-2d-context-desynchronized.yml Outdated Show resolved Hide resolved
features/canvas-2d-context-desynchronized.yml Outdated Show resolved Hide resolved
features/canvas-2d-context-willreadfrequently.yml Outdated Show resolved Hide resolved
features/canvas-2d-context-willreadfrequently.yml Outdated Show resolved Hide resolved
features/canvas-2d-context-willreadfrequently.yml Outdated Show resolved Hide resolved
features/canvas-2d.yml Outdated Show resolved Hide resolved
features/canvas-2d-context-colorspace.yml Outdated Show resolved Hide resolved
features/canvas-2d-context-colorspace.yml Outdated Show resolved Hide resolved
features/canvas-2d-context-alpha.yml Outdated Show resolved Hide resolved
features/canvas-2d-context-alpha.yml Outdated Show resolved Hide resolved
@petele @ddbeck
Apply suggestions from code review
bc14c70 
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
petele
petele commented Aug 16, 2024
View reviewed changes
features/canvas-2d-context-alpha.yml Outdated Show resolved Hide resolved
features/canvas-2d-context-colorspace.yml Outdated Show resolved Hide resolved
features/canvas-2d-context-desynchronized.yml Outdated Show resolved Hide resolved
features/canvas-2d-context-willreadfrequently.yml Outdated Show resolved Hide resolved
features/canvas-2d-context-alpha.yml Outdated Show resolved Hide resolved
features/canvas-2d-context-alpha.yml Outdated Show resolved Hide resolved
@petele petele requested a review from ddbeck August 16, 2024 16:10
@ddbeck ddbeck merged commit 6c0fd81 into web-platform-dx:main Aug 19, 2024
3 checks passed
@petele petele deleted the canvas-2d branch August 19, 2024 15:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ddbeck ddbeck ddbeck approved these changes

@foolip foolip Awaiting requested review from foolip

Assignees
No one assigned
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petele @ddbeck