Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add feature for CSS Typed OM #1847

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

queengooborg
Copy link
Contributor

This PR adds a feature for the CSS Typed OM Level 1.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Sep 25, 2024
@jamesnw
Copy link
Collaborator

jamesnw commented Sep 25, 2024

I'd propose a different approach- many of these keys should be part of separate features. For instance, api.CSS.cap_static should be part of the cap feature, similar to how the highlight feature contains api.CSS.highlights_static.

This feature should contain the keys that are related to CSS syntax and wouldn't be part of other features. Some examples-

  • api.CSSNumericArray
  • api.CSSNumericValue
  • api.CSSUnitValue.value

Some of the keys here can be added to existing features, but there are others like rcap that will still need to be created.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants