update tests

Author: Alex Luu

packages/web3-core/test/unit/__snapshots__/web3_context.test.ts.snap

@@ -137,6 +137,21 @@ describeIf(isWs)('WebSocketProvider - implemented methods', () => {
 			webSocketProvider.disconnect(code);
 			await closePromise;
 		});
+
+		it('should error when no connection is established', async () => {
+			const wsProvider = new WebSocketProvider("ws://localhost:999",{}, { autoReconnect: false });
+			let errored = false;
+			try{
+				await wsProvider.request(jsonRpcPayload);
+				// should not be able to reach here
+				
+			}catch(e){
+				// eslint-disable-next-line jest/no-conditional-expect
+				expect((e as any).message).toBe('Connection not open')
+				errored = true;
+			}
+			expect(errored).toBe(true);
+		});
 	});
 
 	describe('disconnect and reset test', () => {

packages/web3-providers-ws/test/integration/web_socket_provider_integration.test.ts

@@ -23,10 +23,9 @@ export default class WebSocket extends EventEmitter {
 	public CONNECTING = 0;
 	public OPEN = 1;
 
-	public constructor(...args: any[]) {
+	public constructor() {
+		super()
 		// eslint-disable-next-line @typescript-eslint/no-unsafe-call
-		super(...args);
-
 		// Connected state
 		this.readyState = 1;
 	}
@@ -43,13 +42,12 @@ export default class WebSocket extends EventEmitter {
 		}, 100);
 	}
 
-	public addEventListener(event: any, cb: () => void) {
-		// eslint-disable-next-line @typescript-eslint/no-unsafe-call
-		this.prependListener(event, cb);
+	public addEventListener(_event: any, _cb: () => void) {
+		this.on(_event, _cb)
+
 	}
 
-	public removeEventListener(event: any, cb: () => void) {
-		// eslint-disable-next-line @typescript-eslint/no-unsafe-call
-		this.removeListener(event, cb);
+	public removeEventListener(_event: any, _cb: () => void) {
+		this.off(_event, _cb)
 	}
 }

packages/web3-providers-ws/test/unit/__mocks__/isomorphic-ws.ts

@@ -85,28 +85,14 @@ describe('WebSocketProvider', () => {
 			ws.disconnect(code, data);
 			expect(close).toHaveBeenCalledWith(code, data);
 		});
-		it('connection error', async () => {
-			const ws = new WebSocketProvider('ws://localhost:8545');
-			// @ts-expect-error mock method
-			ws._socketConnection.readyState = 2;
-			ws.connect = jest.fn();
-
-			await expect(
-				ws.request({
-					jsonrpc: '2.0',
-					id: 42,
-					method: 'eth_getBalance',
-					params: ['0x407d73d8a49eeb85d32cf465507dd71d507100c1', 'latest'],
-				}),
-			).rejects.toThrow('Connection not open');
-		});
 		it('onCloseEvent autoReconnect=false', () => {
 			const ws = new WebSocketProvider('ws://localhost:8545', {}, { autoReconnect: false });
 			const _clearQueues = jest.fn();
 			const _removeSocketListeners = jest.fn();
 			const _onDisconnect = jest.fn();
 			// @ts-expect-error mock method
 			ws._socketConnection.close = jest.fn();
+			
 			// @ts-expect-error mock method
 			ws._clearQueues = _clearQueues;
 			// @ts-expect-error mock method
@@ -140,7 +126,7 @@ describe('WebSocketProvider', () => {
 			const ws = new WebSocketProvider('ws://localhost:8545');
 			// @ts-expect-error mock method
 			ws._socketConnection.listeners = () => {
-				throw new Error('error');
+					throw new Error('error');
 			};
 			const addEventListener = jest.fn();
 			// @ts-expect-error mock method
@@ -161,6 +147,6 @@ describe('WebSocketProvider', () => {
 			expect(removeEventListener).toHaveBeenCalledWith('open', ws._onOpenHandler);
 			// @ts-expect-error mock method
 			expect(removeEventListener).toHaveBeenCalledWith('close', ws._onCloseHandler);
-		});
+	});
 	});
 });

packages/web3-providers-ws/test/unit/check_implementation.test.ts

@@ -118,7 +118,6 @@ export abstract class SocketProvider<
 
 		this._socketPath = socketPath;
 		this._socketOptions = socketOptions;
-
 		this._reconnectOptions = {
 			...DEFAULT_RECONNECTION_OPTIONS,
 			...(reconnectOptions ?? {}),
@@ -465,7 +464,6 @@ export abstract class SocketProvider<
 		if (this._sentRequestsQueue.has(requestId)) {
 			throw new RequestAlreadySentError(requestId);
 		}
-
 		const deferredPromise = new Web3DeferredPromise<JsonRpcResponseWithResult<ResultType>>();
 		deferredPromise.catch(error => {
 			this._eventEmitter.emit('error', error);