feat(cc-widgets): Style station login component #404

zachraymer · 2025-03-03T21:45:05Z

COMPLETES #< https://jira-eng-sjc12.cisco.com/jira/browse/CAI-6038 >

This pull request addresses

Styles the station login component to more closely match the spec.

by making the following changes

to the presentation layer of the station login component (css and template)

Change Type

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation update
Tooling change
Internal code refactor

The following scenarios were tested

The testing is done with the amplify link
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

Checklist before merging

I have not skipped any automated checks
All existing and new tests passed
I have updated the testing document
I have tested the functionality with amplify link

Make sure to have followed the contributing guidelines before submitting.

coderabbitai · 2025-03-03T21:45:15Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

aws-amplify-us-east-2 · 2025-03-03T21:51:51Z

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-404.d1b38q61t1z947.amplifyapp.com

packages/contact-center/station-login/src/station-login/station-login.style.scss

Shreyas281299

Code changes look good, lets update the branch with latest ccwidgets branch and check the pipeline I believe that the UTs might be failing

mkesavan13

It is essential we use the MRV2 components everywhere. Here's the storybook for the same.

packages/contact-center/station-login/src/station-login/station-login.presentational.tsx

cmullenx · 2025-03-04T17:20:27Z

It is essential we use the MRV2 components everywhere. Here's the storybook for the same.

The MRV2 component is not working and doesnt match the design that we need. The closest match we can get is with native select

Shreyas281299 · 2025-03-04T17:22:49Z

When I change the theme, user-state and tasks components looks good but the station-login is not responding, wouldnt
this be an issue?

zachraymer · 2025-03-04T17:24:48Z

It is essential we use the MRV2 components everywhere. Here's the storybook for the same.

This was difficult because these components were not working for us, and when they did work , they were dramatically different from the spec or they had styling issues due to the tooling of the scss files in this project which are not scoped correctly and interferring with the presentation layers of all components.

mkesavan13 · 2025-03-04T17:26:03Z

It is essential we use the MRV2 components everywhere. Here's the storybook for the same.

The MRV2 component is not working and doesnt match the design that we need. The closest match we can get is with native select

MRV2 won't match the design is expected because we concluded to go with an older library. We will have to Style our way through it. That's what we've did in User state and following in the Call Controls too. Would like to keep it consistent that way

…o ccwidgets

arun3528

LGTM , just fix the merge conflicts

arun3528 · 2025-03-06T19:14:24Z

@mkesavan13 merging it now , let me know if there is any pending items we can work later

sreenara · 2025-03-07T05:46:10Z

🎉 This PR is included in version 1.28.0-ccwidgets.31 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

# [1.28.0-ccwidgets.31](webex/widgets@v1.28.0-ccwidgets.30...v1.28.0-ccwidgets.31) (2025-03-07) ### Features * **cc-widgets:** Style station login component ([webex#404](webex#404)) ([cfb6cf4](webex@cfb6cf4))

Zach Raymer and others added 3 commits February 27, 2025 06:23

stating login modifications

10921f8

Merge branch 'webex:ccwidgets' into ccwidgets

59340c9

modify presentation layer to resemble spec

01620dc

zachraymer changed the title ~~Style station login~~ feat (CC-Widgets): Style station login component Mar 3, 2025

zachraymer changed the title ~~feat (CC-Widgets): Style station login component~~ feat(cc-widgets): Style station login component Mar 3, 2025

Shreyas281299 reviewed Mar 4, 2025

View reviewed changes

packages/contact-center/station-login/src/station-login/station-login.style.scss Outdated Show resolved Hide resolved

Shreyas281299 reviewed Mar 4, 2025

View reviewed changes

Merge branch 'webex:ccwidgets' into ccwidgets

91edfd9

mkesavan13 requested changes Mar 4, 2025

View reviewed changes

Zach Raymer and others added 5 commits March 5, 2025 16:04

using momentum components

1081a15

Merge branch 'ccwidgets' of https://github.com/zachraymer/widgets int…

a00a12b

…o ccwidgets

swap everything for momentum components

3bb9d78

Merge branch 'webex:ccwidgets' into ccwidgets

d7081e2

fix bugs in dropdowns

613701a

zachraymer requested review from mkesavan13 and Shreyas281299 March 6, 2025 16:49

zachraymer and others added 5 commits March 6, 2025 10:52

Merge branch 'ccwidgets' into ccwidgets

3cd8883

Update station-login.presentational.tsx

26eb202

fix merge issues

a31ef44

isolate call control styling

f5a6815

fix failing unit test

b6676f7

arun3528 approved these changes Mar 6, 2025

View reviewed changes

Merge branch 'ccwidgets' into ccwidgets

c0ed87b

arun3528 merged commit cfb6cf4 into webex:ccwidgets Mar 6, 2025
3 checks passed

sreenara added the released on @ccwidgets label Mar 7, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(cc-widgets): Style station login component #404

feat(cc-widgets): Style station login component #404

zachraymer commented Mar 3, 2025 •

edited

Loading

coderabbitai bot commented Mar 3, 2025 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

aws-amplify-us-east-2 bot commented Mar 3, 2025

Shreyas281299 left a comment

mkesavan13 left a comment

cmullenx commented Mar 4, 2025

Shreyas281299 commented Mar 4, 2025 •

edited

Loading

zachraymer commented Mar 4, 2025

mkesavan13 commented Mar 4, 2025

arun3528 left a comment

arun3528 commented Mar 6, 2025

sreenara commented Mar 7, 2025

feat(cc-widgets): Style station login component #404

feat(cc-widgets): Style station login component #404

Conversation

zachraymer commented Mar 3, 2025 • edited Loading

COMPLETES #< https://jira-eng-sjc12.cisco.com/jira/browse/CAI-6038 >

This pull request addresses

by making the following changes

Change Type

The following scenarios were tested

Checklist before merging

coderabbitai bot commented Mar 3, 2025 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

aws-amplify-us-east-2 bot commented Mar 3, 2025

Shreyas281299 left a comment

Choose a reason for hiding this comment

mkesavan13 left a comment

Choose a reason for hiding this comment

cmullenx commented Mar 4, 2025

Shreyas281299 commented Mar 4, 2025 • edited Loading

zachraymer commented Mar 4, 2025

mkesavan13 commented Mar 4, 2025

arun3528 left a comment

Choose a reason for hiding this comment

arun3528 commented Mar 6, 2025

sreenara commented Mar 7, 2025

zachraymer commented Mar 3, 2025 •

edited

Loading

coderabbitai bot commented Mar 3, 2025 •

edited

Loading

Shreyas281299 commented Mar 4, 2025 •

edited

Loading