feat(cc-widgets): added new UI for call controls #405

rsarika · 2025-03-05T11:05:27Z

https://app.vidcast.io/share/2b6a8be0-f839-4e35-be73-a7f8006cf3f3

coderabbitai · 2025-03-05T11:05:35Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

aws-amplify-us-east-2 · 2025-03-05T11:11:45Z

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-405.d1b38q61t1z947.amplifyapp.com

mkesavan13 · 2025-03-05T12:37:28Z

packages/contact-center/task/src/CallControl/call-control.presentational.tsx


 import {CallControlPresentationalProps} from '../task.types';
 import './call-control.styles.scss';
-import {ButtonPill} from '@momentum-ui/react-collaboration';
+import {Button, Icon} from '@momentum-design/components/dist/react';


Why are we using the @momentum-design components for these? Shouldn't everything come from react-collaboration?

We have ButtonCircle as well as Icon

updated button. icon kept as it is as collaboration icons works properly. we can fix it once we fix i con issue

mkesavan13

Please check the comments

mkesavan13 · 2025-03-05T17:25:59Z

packages/contact-center/task/src/CallControl/call-control.presentational.tsx

+      tooltip: isHeld ? 'Resume the call' : 'Hold the call',
+      className: 'call-control-button',
+    },
+    {
+      icon: isRecording ? 'record-paused-bold' : 'record-bold',
+      onClick: () => handletoggleRecording(),
+      tooltip: isRecording ? 'Pause Recording' : 'Resume Recording',
+      className: 'call-control-button',
+    },
+    {
+      icon: 'cancel-regular',
+      onClick: endCall,
+      tooltip: 'End call',


Can we add all the tooltip text and UI labels to a constant file?

mkesavan13 · 2025-03-05T17:27:07Z

packages/contact-center/task/src/CallControl/call-control.presentational.tsx

+              <Text className="wrapup-header" tagName={'small'} type="subheader-primary">
+                Wrap-up Interaction
+              </Text>


This one doesn't match the Figma Specs. In terms of positioning, size and weight. Please check.

mkesavan13 · 2025-03-05T17:28:11Z

packages/contact-center/task/src/CallControl/call-control.presentational.tsx

+                Wrap-up Interaction
+              </Text>
+              <div className="wrapup-select-wrapper">
+                <SelectNext


This select component height and width as well doesn't match with the Figma specs. Please check.

mkesavan13 · 2025-03-05T17:28:56Z

packages/contact-center/task/src/CallControl/call-control.presentational.tsx

+              className="wrapup-popover"
+            >
+              <Text className="wrapup-header" tagName={'small'} type="subheader-primary">
+                Wrap-up Interaction


Can we have this label in a constant file?

We have many texts that are directly added in the HTML, is it okay that we have a ticket for i18n and we move everything as part of that?

mkesavan13 · 2025-03-05T17:29:11Z

packages/contact-center/task/src/CallControl/call-control.presentational.tsx

+                  items={wrapupCodes}
+                  showBorder={false}
+                  placeholder="Select"
+                  label="Wrap-up reason"


Let's add this label to constants as well

mkesavan13 · 2025-03-05T17:29:54Z

packages/contact-center/task/src/CallControl/call-control.presentational.tsx

+                onPress={() => wrapupCall(selectedWrapupReason, selectedWrapupId)}
+                disabled={selectedWrapupId && selectedWrapupReason ? false : true}
+              >
+                submit & Wrapup


Suggested change

submit & Wrapup

Submit & Wrap up

Also ensure that this comes from the constant file

mkesavan13 · 2025-03-05T17:30:49Z

packages/contact-center/task/src/CallControl/call-control.presentational.tsx

-import {ButtonPill} from '@momentum-ui/react-collaboration';
+import {PopoverNext, SelectNext, TooltipNext, Text, ButtonCircle, ButtonPill} from '@momentum-ui/react-collaboration';
+import {Item} from '@react-stately/collections';
+import {Icon} from '@momentum-design/components/dist/react';


Can't we import <IconNext/> instead from the MRV2 itself for this?

CC - @Shreyas281299

No we cant, the IconNext is not working. This component is the reason why SelectNext and other components with Icons are not working.

mkesavan13 · 2025-03-05T17:31:54Z

packages/contact-center/task/src/CallControl/call-control.presentational.tsx

+        )}
+        {wrapupRequired && (
+          <div className="wrapup-group">
+            <PopoverNext


Let's also check if the popover style matches the Figma. For instance, the border & padding in the Figma and the vidcast doesn't seem to match

Shreyas281299 · 2025-03-06T13:13:42Z

Screen.Recording.2025-03-06.at.6.40.04.PM.mov

Testing after my commit to fix UTs

Shreyas281299

Changes look good, Lets just update the UI according to the Figma as mentioned by Kesava

Shreyas281299 · 2025-03-06T13:49:08Z

Updated UI

…new-UI

sreenara · 2025-03-06T16:39:05Z

🎉 This PR is included in version 1.28.0-ccwidgets.29 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

# [1.28.0-ccwidgets.29](webex/widgets@v1.28.0-ccwidgets.28...v1.28.0-ccwidgets.29) (2025-03-06) ### Features * **cc-widgets:** added new UI for call controls ([webex#405](webex#405)) ([e48f48d](webex@e48f48d))

feat(cc-widgets): added new UI for call controls

51e967f

fix: removed unused css

857b28e

rsarika requested a review from mkesavan13 March 5, 2025 11:18

fix: updated onClick

5df323a

mkesavan13 reviewed Mar 5, 2025

View reviewed changes

rsarika added 2 commits March 5, 2025 20:03

fix: updated css

44fbf5a

fix: updated UI with proper buttons

ab8268a

mkesavan13 requested changes Mar 5, 2025

View reviewed changes

rsarika and others added 2 commits March 6, 2025 11:48

fix: auto wrapup issue

8d97eb4

fix(cc-task): review-comments-fix-uts

7251e14

Shreyas281299 reviewed Mar 6, 2025

View reviewed changes

fix(cc-task): update-css-and-ui

11c9b30

Merge remote-tracking branch 'upstream/ccwidgets' into call-controls-…

aef5abe

…new-UI

Shreyas281299 approved these changes Mar 6, 2025

View reviewed changes

mkesavan13 approved these changes Mar 6, 2025

View reviewed changes

fix(cc-task): text-update

c531e85

Shreyas281299 merged commit e48f48d into webex:ccwidgets Mar 6, 2025
3 checks passed

sreenara added the released on @ccwidgets label Mar 6, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(cc-widgets): added new UI for call controls #405

feat(cc-widgets): added new UI for call controls #405

rsarika commented Mar 5, 2025 •

edited

Loading

coderabbitai bot commented Mar 5, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

aws-amplify-us-east-2 bot commented Mar 5, 2025

mkesavan13 Mar 5, 2025

mkesavan13 Mar 5, 2025 •

edited

Loading

rsarika Mar 5, 2025

mkesavan13 left a comment

mkesavan13 Mar 5, 2025

mkesavan13 Mar 5, 2025

Shreyas281299 Mar 6, 2025

mkesavan13 Mar 5, 2025

Shreyas281299 Mar 6, 2025

mkesavan13 Mar 5, 2025

Shreyas281299 Mar 6, 2025

mkesavan13 Mar 5, 2025

mkesavan13 Mar 5, 2025

Shreyas281299 Mar 6, 2025

mkesavan13 Mar 5, 2025

Shreyas281299 Mar 6, 2025

mkesavan13 Mar 5, 2025

Shreyas281299 Mar 6, 2025

Shreyas281299 commented Mar 6, 2025

Shreyas281299 left a comment

Shreyas281299 commented Mar 6, 2025

sreenara commented Mar 6, 2025

feat(cc-widgets): added new UI for call controls #405

feat(cc-widgets): added new UI for call controls #405

Conversation

rsarika commented Mar 5, 2025 • edited Loading

coderabbitai bot commented Mar 5, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

aws-amplify-us-east-2 bot commented Mar 5, 2025

Choose a reason for hiding this comment

mkesavan13 Mar 5, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mkesavan13 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Shreyas281299 commented Mar 6, 2025

Shreyas281299 left a comment

Choose a reason for hiding this comment

Shreyas281299 commented Mar 6, 2025

sreenara commented Mar 6, 2025

rsarika commented Mar 5, 2025 •

edited

Loading

mkesavan13 Mar 5, 2025 •

edited

Loading