Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(cc-task): update colors for Task Item #406

Merged
merged 12 commits into from
Mar 6, 2025

Conversation

cmullenx
Copy link

@cmullenx cmullenx commented Mar 5, 2025

COMPLETES # https://jira-eng-sjc12.cisco.com/jira/browse/CAI-6035

This pull request addresses

Updates Font Color and Button Color in Task Item

by making the following changes

  • Updates the End Button Text to Red
  • Changes text color of list item to match the figma
Screenshot 2025-03-05 at 1 50 46 PM Screenshot 2025-03-05 at 1 50 55 PM

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios were tested

  • The testing is done with the amplify link
    Manually testing the UI locally

Checklist before merging

  • I have not skipped any automated checks
  • All existing and new tests passed
  • I have updated the testing document
  • I have tested the functionality with amplify link

Make sure to have followed the contributing guidelines before submitting.

Copy link

coderabbitai bot commented Mar 5, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-406.d1b38q61t1z947.amplifyapp.com

Copy link
Contributor

@mkesavan13 mkesavan13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Since this is a custom button, please check if the button style matches any other button from any part of the Figma
  • Please change the PR title from fix(cc-widgets) to fix(cc-task) as your change is more relevant to task

@cmullenx
Copy link
Author

cmullenx commented Mar 6, 2025

  • Since this is a custom button, please check if the button style matches any other button from any part of the Figma
  • Please change the PR title from fix(cc-widgets) to fix(cc-task) as your change is more relevant to task

I have changed the title. However, this isn't a custom button, its the Button component from momentum using one of the colors it accepts as props.

@cmullenx cmullenx changed the title fix(cc-widgets): update colors for Task Item fix(cc-task): update colors for Task Item Mar 6, 2025
@arun3528 arun3528 merged commit 08cb2aa into webex:ccwidgets Mar 6, 2025
3 checks passed
@sreenara
Copy link
Contributor

sreenara commented Mar 6, 2025

🎉 This PR is included in version 1.28.0-ccwidgets.28 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

cmullenx pushed a commit to cmullenx/widgets that referenced this pull request Mar 6, 2025
# [1.28.0-ccwidgets.28](webex/widgets@v1.28.0-ccwidgets.27...v1.28.0-ccwidgets.28) (2025-03-06)

### Bug Fixes

* **cc-task:** update colors for Task Item ([webex#406](webex#406)) ([08cb2aa](webex@08cb2aa))
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants