-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix(cc-task): update colors for Task Item #406
Conversation
…script, use rems instead of pixels
fix(task): remove-ui-testing
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Since this is a custom button, please check if the button style matches any other button from any part of the Figma
- Please change the PR title from fix(cc-widgets) to fix(cc-task) as your change is more relevant to task
I have changed the title. However, this isn't a custom button, its the Button component from momentum using one of the colors it accepts as props. |
🎉 This PR is included in version 1.28.0-ccwidgets.28 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
# [1.28.0-ccwidgets.28](webex/widgets@v1.28.0-ccwidgets.27...v1.28.0-ccwidgets.28) (2025-03-06) ### Bug Fixes * **cc-task:** update colors for Task Item ([webex#406](webex#406)) ([08cb2aa](webex@08cb2aa))
COMPLETES # https://jira-eng-sjc12.cisco.com/jira/browse/CAI-6035
This pull request addresses
Updates Font Color and Button Color in Task Item
by making the following changes
Change Type
The following scenarios were tested
Manually testing the UI locally
Checklist before merging
Make sure to have followed the contributing guidelines before submitting.