Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Hardcoded service_worker file breaks when using custom service_worker #204

Closed
tm1000 opened this issue Jun 3, 2022 · 0 comments
Closed

Hardcoded service_worker file breaks when using custom service_worker #204

tm1000 opened this issue Jun 3, 2022 · 0 comments

Comments

@tm1000
Copy link
Member

tm1000 commented Jun 3, 2022 •
edited
Loading

The script name needs to be retrieved from the manifest file instead of being hardcoded.

See:

webpack-webextension-plugin/src/plugin/index.ts

Line 168 in a92caee

if (assets["scripts/service_worker.js"]) {

Reference: webextension-toolbox/webextension-toolbox#82

Thanks to @j1mie for the find
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tm1000