Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

docs: remove "$" from copied console line #578

Merged
merged 1 commit into from
Jan 25, 2021

Conversation

feisk
Copy link
Contributor

@feisk feisk commented Jan 25, 2021

For easy copying of the plugin installation command

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

For easy copying of the plugin installation command
@codecov
Copy link

codecov bot commented Jan 25, 2021

Codecov Report

Merging #578 (8bf0a0d) into master (46af20a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #578   +/-   ##
=======================================
  Coverage   92.98%   92.98%           
=======================================
  Files           3        3           
  Lines         285      285           
  Branches       78       78           
=======================================
  Hits          265      265           
  Misses         20       20           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46af20a...8bf0a0d. Read the comment docs.

@alexander-akait
Copy link
Member

Why? We use it for any scripts to point what it is script

@feisk
Copy link
Contributor Author

feisk commented Jan 25, 2021

Why? We use it for any scripts to point what it is script

For consistency of webpack plugin descriptions

@feisk feisk changed the title Remove "$" from copied console line docs: remove "$" from copied console line Jan 25, 2021
@alexander-akait
Copy link
Member

can you provide example of others?

@feisk
Copy link
Contributor Author

feisk commented Jan 25, 2021

yes, for example here:
https://github.com/webpack-contrib/eslint-webpack-plugin
https://github.com/webpack-contrib/mini-css-extract-plugin

and here https://webpack.js.org/plugins/html-webpack-plugin/
Снимок экрана 2021-01-25 в 14 42 57

When I want to quickly copy the line to install the plugin package, I copy the whole line, in this case it is much easier

@alexander-akait
Copy link
Member

oh, yes, I see, thanks

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants