Skip to content

Fix url filter behavior #891

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
rodfersou opened this issue Feb 6, 2019 · 3 comments · Fixed by #939
Closed

Fix url filter behavior #891

rodfersou opened this issue Feb 6, 2019 · 3 comments · Fixed by #939

Comments

@rodfersou
Copy link

Related to: #779

The result of the function should be inverted to keep in mind the same behavior when it is a boolean..
I mean when the function return false should not look the url.
This is my configuration in the end:

    {
      test: /\.scss$/,
      use: ExtractTextPlugin.extract({
        fallback: 'style-loader',
        use: [
          {
            loader: 'css-loader',
            options: {
              url: (url, resourcePath) => /\+\+resource\+\+/.test(url)
            }
          },
          'postcss-loader',
          'sass-loader'
        ]
      }),
    },
@alexander-akait
Copy link
Member

@rodfersou thanks for issue, we can fix it only in next major release, i am afraid break loader for other developers

@rodfersou
Copy link
Author

@evilebottnawi for me looks great!

@rodfersou
Copy link
Author

🎉

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants