Skip to content
This repository was archived by the owner on Sep 28, 2020. It is now read-only.

mkdirp module cannot be found #166

Closed
davazp opened this issue Mar 23, 2017 · 4 comments
Closed

mkdirp module cannot be found #166

davazp opened this issue Mar 23, 2017 · 4 comments

Comments

@davazp
Copy link

davazp commented Mar 23, 2017

The problem affects the latest release. It seems caused by the recently added loader-fs-cache dependency, which does not include mkdirp in the dependency list (but it uses it).

I have reported it viankakrisna/loader-fs-cache#1, but I created this issue for people experiencing the same problem.

@jeremywiebe
Copy link

I've just run into this problem also. Given that this 1.7.0 release is obviously broken, would it be possible to roll back the loader-fs-cache and release 1.7.1 and then iron out the issues in this bug report?

Right now this is completely breaking eslint-loader.

/cc @MoOx @viankakrisna

@viankakrisna
Copy link
Contributor

Sorry for the breakage! it's now released as 1.0.1

@MoOx
Copy link
Contributor

MoOx commented Mar 23, 2017

@davazp @jeremywiebe In this kind of scenario, the best thing to do is to use ~1.6.0 so you don't get the "bug". Reverting an improvement because of a small thing that you can workaround by having mkdir around or using an old version look crazy to me. Opening a PR to add the missing dep will take the same time as commenting here btw.

@viankakrisna no problem, this kind of things happen :) Thanks for fixing this quickly!

@MoOx MoOx closed this as completed Mar 23, 2017
@jeremywiebe
Copy link

@viankakrisna that was fast! Thank you.

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants