Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Remove unused v dependency #517

Merged
merged 1 commit into from
May 31, 2023
Merged

fix: Remove unused v dependency #517

merged 1 commit into from
May 31, 2023

Conversation

askoufis
Copy link
Contributor

@askoufis askoufis commented May 31, 2023

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Seems like a dependency on the v package was added during this chore PR. This seems like an accident to me as the v package doesn't seem related at all to less-loader.

@ctjhoa
Copy link

ctjhoa commented May 31, 2023

I came to the same conclusion and I agree,
In addition, this dependency is annoying because it brings deasync which relies on
node-gyp internally (notorious for being clunky).

@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8b9c873) 93.37% compared to head (710ac31) 93.37%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #517   +/-   ##
=======================================
  Coverage   93.37%   93.37%           
=======================================
  Files           3        3           
  Lines         151      151           
  Branches       33       33           
=======================================
  Hits          141      141           
  Misses         10       10           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alexander-akait alexander-akait merged commit 8fd9206 into webpack-contrib:master May 31, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants