Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: optimize debug message formatting, #1065 #1066

Merged
merged 5 commits into from
Jun 20, 2022
Merged

feat: optimize debug message formatting, #1065 #1066

merged 5 commits into from
Jun 20, 2022

Conversation

webdiscus
Copy link
Contributor

docs: add impofration how to enable @debug output

This PR contains a:

  • bugfix
  • [x ] new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

  1. The debug message on each line is too long because the output contains an absolute file before self message.
    Here was changed debug message formatting to: [debug:line:column] message.
  2. In readme is added "How to enable @debug output", because since sass-loader 1.12.0 the output of @debug is disabled by default.

Details see in the issue.

Breaking Changes

NO

Additional Info

docs: add impofration how to enable @debug output
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 16, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@webdiscus
Copy link
Contributor Author

@alexander-akait

in my last commit test: change expected values in snap for optimized @debug output are fixed test snaps, now all test are passed.

@alexander-akait
Copy link
Member

Can you fix an error error?

@codecov
Copy link

codecov bot commented Jun 19, 2022

Codecov Report

Merging #1066 (4c85182) into master (f6e624a) will decrease coverage by 0.23%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1066      +/-   ##
==========================================
- Coverage   94.33%   94.10%   -0.24%     
==========================================
  Files           5        5              
  Lines         371      373       +2     
  Branches      137      137              
==========================================
+ Hits          350      351       +1     
  Misses         19       19              
- Partials        2        3       +1     
Impacted Files Coverage Δ
src/utils.js 92.76% <100.00%> (-0.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6e624a...4c85182. Read the comment docs.

@webdiscus
Copy link
Contributor Author

Can you fix an error error?

This is not code error, this is Lint error:

[lint:prettier] src/utils.js
ERROR: "lint:prettier" exited with 1.
Error: Process completed with exit code 1.

It was already in master before I cloned it.

I try to find the error. I can reproduce this issue by me local with npm run lint

@alexander-akait
Copy link
Member

Yes, can you fix it?

@webdiscus
Copy link
Contributor Author

webdiscus commented Jun 19, 2022

Yes, can you fix it?

Yes, I can.
Now are passed both the lint and the tests.

@alexander-akait alexander-akait merged commit 49a578a into webpack-contrib:master Jun 20, 2022
@alexander-akait
Copy link
Member

Thank you

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants