Skip to content
This repository has been archived by the owner on Jul 13, 2021. It is now read-only.

Webpack 5: Update ParserHelpers to JavascriptParserHelpers #111

Open
mvattuone opened this issue Jan 6, 2020 · 3 comments
Open

Webpack 5: Update ParserHelpers to JavascriptParserHelpers #111

mvattuone opened this issue Jan 6, 2020 · 3 comments

Comments

@mvattuone
Copy link

mvattuone commented Jan 6, 2020

  • Operating System: Mac OSX
  • Node Version: 10.15
  • NPM Version: 6.7
  • webpack Version: 5.0.0-beta.11
  • webpack-hot-client Version: latest

Feature Proposal

Maybe this is a "bug", but given I'm using a pre-RC version of webpack 5, I didn't want to make it seem like something is wrong.

Is there a plan to update 'webpack/lib/ParserHelpers' to 'webpack/lib/javascript/JavascriptParserHelpers' to make this package compatible with Webpack 5?

Here, I have it forked, and I'm happy to make a PR against the package, but I didn't want to necessarily rush things if that was intended for the next major version.

mvattuone@eb1465e

Feature Use Case

Again, this might not be in scope, but I am still using webpack-serve which uses this package. I do not directly include it.

Perhaps I should instead use webpack-dev-server, but I wasn't clear on whether this package is used elsewhere and might need to updated regardless.

@droganov
Copy link

droganov commented Apr 14, 2020

Same issue when using koa-webpack with Webpack 5

internal/modules/cjs/loader.js:626
throw err;
^

Error: Cannot find module 'webpack/lib/ParserHelpers'
Require stack:
- /www/maintined/rkta-starter/node_modules/webpack-hot-client/lib/compiler.js
- /www/maintined/rkta-starter/node_modules/webpack-hot-client/lib/index.js
- /www/maintined/rkta-starter/node_modules/koa-webpack/lib/client.js
- /www/maintined/rkta-starter/node_modules/koa-webpack/lib/index.js

@neenhouse
Copy link

neenhouse commented Sep 1, 2020

This issue should be addressed to better support webpack 5 release (ETA ~ 1 month): webpack/webpack#11406 otherwise webpack process critically fails

@mvattuone might be a good time to open your fork? master...mvattuone:master

@mvattuone
Copy link
Author

@neenhouse I made a PR. I am not using this anymore and moved to webpack-dev-server, but I hope that someone looks into this further or at least admits that they aren't planning on supporting this package moving forward.

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants