Skip to content
This repository has been archived by the owner on Jul 13, 2021. It is now read-only.

Add Ability to Broadcast to Client Sockets #39

Merged
merged 1 commit into from
Mar 24, 2018
Merged

Conversation

shellscape
Copy link
Contributor

  • This is a bugfix
  • This is a new feature
  • This is a code refactor
  • This is a test update
  • This is a typo fix
  • This is a metadata update

For Bugs and Features; did you add new tests?

Yes

Motivation / Use-Case

For certain recipes, such as watching files or implementing progress feedback, the socket server needs the ability to accept and broadcast a message to all other client sockets. For instance, to reload the window.

This PR adds that ability, and adds a new socket handler in the client, window-reload which serves only to reload the page without any special logic.

Breaking Changes

None

Additional Info

@codecov
Copy link

codecov bot commented Mar 24, 2018

Codecov Report

Merging #39 into master will increase coverage by 0.64%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
+ Coverage   85.43%   86.07%   +0.64%     
==========================================
  Files           3        3              
  Lines         151      158       +7     
==========================================
+ Hits          129      136       +7     
  Misses         22       22
Impacted Files Coverage Δ
index.js 87.95% <100%> (+1.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8efd4e6...312ad7e. Read the comment docs.

@shellscape shellscape merged commit 810fda2 into master Mar 24, 2018
@shellscape shellscape deleted the socket-broadcast branch March 24, 2018 15:15
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant