This repository has been archived by the owner on Apr 8, 2019. It is now read-only.
refactor: use config-loader #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ update to latest eslint-config-webpack
shellscape
requested review from
ooflorent,
TheLarkInn,
alexander-akait and
joshwiens
Codecov Report
@@ Coverage Diff @@
## master #126 +/- ##
==========================================
+ Coverage 93% 96.65% +3.65%
==========================================
Files 7 7
Lines 300 269 -31
==========================================
- Hits 279 260 -19
+ Misses 21 9 -12
Continue to review full report at Codecov.
|
ooflorent
suggested changes
May 10, 2018
cli.js
Outdated
| @@ -14,7 +12,7 @@ const cosmiconfig = require('cosmiconfig'); | |||
| const debug = require('debug')('webpack-serve'); | |||
| const meow = require('meow'); | |||
| const merge = require('lodash/merge'); | |||
| const resolveModule = require('resolve').sync; | |||
| // const resolveModule = require('resolve').sync; | |||
There was a problem hiding this comment.
Could you remove the comment?
cli.js
Outdated
|
|
||
| const flags = Object.assign({}, cli.flags); | ||
|
|
||
| if (flags.require) { |
There was a problem hiding this comment.
Why did you remove this option?
There was a problem hiding this comment.
it's handled by config-loader downstream
lib/options.js
Outdated
| 'use strict'; | ||
|
|
||
| const path = require('path'); | ||
| // const path = require('path'); |
shellscape
force-pushed
the
refactor/config-loader
branch
2 times, most recently
from
b5a34fb to
ca9aaaf
Compare
shellscape
force-pushed
the
refactor/config-loader
branch
from
ca9aaaf to
194f1df
Compare
shellscape
force-pushed
the
refactor/config-loader
branch
from
8a30514 to
34b9d98
Compare
|
@evilebottnawi it does not break |
alexander-akait
approved these changes
May 10, 2018
ooflorent
approved these changes
May 10, 2018
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
+ update to latest eslint-config-webpack
This PR contains a:
Motivation / Use-Case
@webpack-contrib/config-loaderprovides many advantages for loading webpack configs, including supporting all export formats of config that can be used out of the gate bywebpack-cliandwebpack-command. It also allows for require hooks for loading configs, and for different file formats for config files.Breaking Changes
None
Additional Info