This repository has been archived by the owner on Apr 8, 2019. It is now read-only.
Fix event emitter example code in README #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`serve.on` is undefined, so the current example errors out. I've copied the approach used in the event unit tests: https://github.com/webpack-contrib/webpack-serve/blob/bb84692969a672eaa18865c98f6f045aa57bf3c5/test/tests/events.js
|
|
Codecov Report
@@ Coverage Diff @@
## master #52 +/- ##
=======================================
Coverage 92.19% 92.19%
=======================================
Files 7 7
Lines 269 269
=======================================
Hits 248 248
Misses 21 21Continue to review full report at Codecov.
|
|
@TrevorBurnham thanks for the PR 🍺 And thanks for pointing out the discrepancy. Please note for the future that we typically close PRs (and issues) that have removed bits of the template. Heck, even the maintainers fill out the whole thing for their PRs. Please sign that CLA and we'll get this one merged. |
Done. 📝 |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
serve.onis undefined, so the current example under the "Events" heading errors out. I've copied the approach used in the event unit tests: https://github.com/webpack-contrib/webpack-serve/blob/bb84692969a672eaa18865c98f6f045aa57bf3c5/test/tests/events.js