This repository has been archived by the owner on Apr 8, 2019. It is now read-only.
Open option fixes #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update how open flags are used in code and applied to options update cli description for --open-app
6 tasks
Codecov Report
@@ Coverage Diff @@
## master #72 +/- ##
========================================
+ Coverage 92.19% 92.7% +0.5%
========================================
Files 7 7
Lines 269 274 +5
========================================
+ Hits 248 254 +6
+ Misses 21 20 -1
Continue to review full report at Codecov.
|
| @@ -46,7 +46,8 @@ const cli = meow(chalk` | |||
| --no-hot Instruct the client not to apply Hot Module Replacement patches | |||
| --no-reload Instruct middleware {italic not} to reload the page for build errors | |||
| --open Instruct the app to open in the default browser | |||
| --open-app The name of the app to open the app within | |||
| --open-app The name of the app to open the app within, or an array | |||
| containing the app name and arguments for the app | |||
There was a problem hiding this comment.
I think this argument requires more explanation. It needs to be clear this is a JSON array, not a JavaScript array (i.e. ['a', 'b', 'c',] wouldn't work). Otherwise the console warning could be confusing to users.
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Supersedes #60. There was some parsing on the
--open-appflag that wasn't correct in all scenarios, and parsing of--open-paththat was incorrect. The code was also passing all of theopenoptions blindly toopn, which could cause issues in the future. The tests were updated to more thoroughly check theopenoption's properties and how they are passed toopn.Breaking Changes
None
Additional Info
N/A