feat: support HEAD method by default (#398)

webpack · May 14, 2019 · ec3d5eb · TrejGun · May 15, 2019 · ec3d5eb
1 parent f227570
commit ec3d5eb
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -70,7 +70,7 @@ _Note: The `publicPath` property is required, whereas all other options are opti
 ### methods
 
 Type: `Array`  
-Default: `[ 'GET' ]`
+Default: `[ 'GET', 'HEAD' ]`
 
 This property allows a user to pass the list of HTTP request methods accepted by the server.
 

diff --git a/lib/middleware.js b/lib/middleware.js
@@ -44,7 +44,7 @@ module.exports = function wrapper(context) {
       });
     }
 
-    const acceptedMethods = context.options.methods || ['GET'];
+    const acceptedMethods = context.options.methods || ['GET', 'HEAD'];
 
     if (acceptedMethods.indexOf(req.method) === -1) {
       return goNext();

diff --git a/test/server.test.js b/test/server.test.js
@@ -93,6 +93,15 @@ describe('Server', () => {
         .expect(200, /console\.log\('Hey\.'\)/, done);
     });
 
+    it('HEAD request to bundle file', (done) => {
+      request(app)
+        .head('/public/bundle.js')
+        .expect('Content-Type', 'application/javascript; charset=UTF-8')
+        .expect('Content-Length', '4631')
+        // eslint-disable-next-line no-undefined
+        .expect(200, undefined, done);
+    });
+
     it('POST request to bundle file', (done) => {
       request(app)
         .post('/public/bundle.js')
@@ -190,6 +199,12 @@ describe('Server', () => {
         .get('/public/bundle.js')
         .expect(404, done);
     });
+
+    it("HEAD request to bundle file with methods set to ['POST']", (done) => {
+      request(app)
+        .get('/public/bundle.js')
+        .expect(404, done);
+    });
   });
 
   describe('no index mode', () => {