Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: compatibility with webpack@5 #473

Merged
merged 1 commit into from
Sep 28, 2019

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

compatibility with latest webpack@5

Breaking Changes

No

Additional Info

webpack@5 has regression in invalidate method, so temporary comment some part of test (already written to sokra about this)

Also many test uses context: '/', it is invalid, context should be full path to directory.

This code:

// TODO Why? Need remove in future major release
              if (outputPath === '/') {
                outputPath = compiler.context;
              }

just workaround with invalid tests, i don't know why previously developer do this, maybe he did not understand or did not know how to write tests, this will remain a mystery to us

filename: 'bundle.js',
path: '/',
},
});
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As i written above we should rewrite tests in future

@codecov
Copy link

codecov bot commented Sep 28, 2019

Codecov Report

Merging #473 into master will decrease coverage by 0.28%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #473      +/-   ##
==========================================
- Coverage   97.37%   97.09%   -0.29%     
==========================================
  Files           7        7              
  Lines         305      310       +5     
  Branches      101      102       +1     
==========================================
+ Hits          297      301       +4     
- Misses          8        9       +1
Impacted Files Coverage Δ
lib/fs.js 95.52% <93.33%> (-1.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6730076...a707dad. Read the comment docs.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant