Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update chokidar to v4 #5368

Open
Fuzzyma opened this issue Dec 4, 2024 · 7 comments · May be fixed by #5374
Open

Update chokidar to v4 #5368

Fuzzyma opened this issue Dec 4, 2024 · 7 comments · May be fixed by #5374

Comments

@Fuzzyma
Copy link

Fuzzyma commented Dec 4, 2024

Bug report

This is not a bug report but I didn't know where to put it.
I would like to propose updating chokidar to v4. This would reduce the dependency count by 11 and also improves typing.
I am opening this issue as part of the ecosystem cleanup initiative (https://e18e.dev). We are trying to modernize the ecosystem by reducing dependency bloat, package size or improve speed.

If you are open for this, I would be happy to create a PR and do the necessary changes!

Actual Behavior

Expected Behavior

How Do We Reproduce?

Please paste the results of npx webpack-cli info here, and mention other relevant information

@alexander-akait
Copy link
Member

alexander-akait commented Dec 5, 2024

@Fuzzyma I am afraid we can't do it right now, due - https://github.com/paulmillr/chokidar/releases/tag/4.0.0

Remove glob support

It will be breaking change for us

@Fuzzyma
Copy link
Author

Fuzzyma commented Dec 5, 2024

Ah I see. I actually faced the same problem over at tailwindcss. One community member (@talentlessguy) suggested this solution:

chokidar.watch(paths.map(p => isGlob(p) ? tinyglobby(p) : p))

Would that maybe work?

@alexander-akait
Copy link
Member

@Fuzzyma This can work, need to test if it will work with creating nested directories, but I think it should

@benmccann
Copy link

It should work. One more suggestion: you can replace isGlob with isDynamicPattern from tinyglobby, so that you don't need an additional library for that

@Fuzzyma
Copy link
Author

Fuzzyma commented Dec 7, 2024

When looking into this I hit a blocker with chokidar and would like to wait for the resolution before I put more work into it.

// EDIT:

Ok, with the fix that I proposed to chokidar I made it work. If the change to chokidar is not accepted I need to add a small workaround. Will create a PR for review tomorrow

@Fuzzyma Fuzzyma linked a pull request Dec 8, 2024 that will close this issue
6 tasks
@Anubhab2003
Copy link

Hey I am Interested in this issue, How to get started

@Fuzzyma
Copy link
Author

Fuzzyma commented Jan 3, 2025

@Anubhab2003 a pr already exists and is ready to be merged. Nothing to do here :D

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants