Skip to content

Refactor table inputs to use ElementInternals #2536

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
SuaYoo opened this issue Apr 7, 2025 · 1 comment
Open

Refactor table inputs to use ElementInternals #2536

SuaYoo opened this issue Apr 7, 2025 · 1 comment
Assignees
@SuaYoo
Labels
front end Requires front end dev work

Comments

@SuaYoo
Copy link
Member

SuaYoo commented Apr 7, 2025 •
edited
Loading

This removes the need to manually call checkValidity and reportValidity on custom components. https://developer.mozilla.org/en-US/docs/Web/API/ElementInternals

Additionally, error display should be standardized into a tooltip.
@SuaYoo SuaYoo added the front end Requires front end dev work label Apr 7, 2025
@SuaYoo SuaYoo self-assigned this Apr 7, 2025
@ikreymer ikreymer moved this from Triage to Todo in Webrecorder Projects Apr 7, 2025
This was referenced Apr 7, 2025
Open
Merged
@SuaYoo
Copy link
Member Author

SuaYoo commented Apr 7, 2025

cc @emma-sg putting on your radar

@SuaYoo SuaYoo changed the title Refactor inputs to use ElementInternals Refactor table inputs to use ElementInternals Apr 22, 2025
@SuaYoo SuaYoo moved this from Todo to Implementing in Webrecorder Projects Apr 23, 2025
@SuaYoo SuaYoo mentioned this issue Apr 23, 2025
Open
@SuaYoo SuaYoo mentioned this issue May 5, 2025
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@SuaYoo SuaYoo

Labels
front end Requires front end dev work
Projects
Webrecorder Projects
Status: Implementing
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SuaYoo