-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Enhance Jetpack Compatibility #855
Comments
@jaswsinc Unable to reproduce bug as experienced by customerAre there any additional details or steps needed to test further? WordPress Version: 4.6.1 Steps taken
There was no issue with loading any of the Sidebar Widgets, and they showed properly if configured with the right settings. |
Here are some extra details I could gather from the thread, as well as with some testing:
curl -I http://www.cookingwithpeachy.com/wordpress/wp-json/oembed/1.0
HTTP/1.1 301 Moved Permanently
Date: Thu, 01 Dec 2016 14:48:08 GMT
Server: Apache
Location: http://www.cookingwithpeachy.com/wp-json/oembed/1.0/
Cache-Control: max-age=2592000
Expires: Sat, 31 Dec 2016 14:48:08 GMT
Vary: Accept-Encoding
Content-Type: text/html; charset=iso-8859-1
|
I also ran Comet Cache Pro v161119 + Jetpack v4.4.1 through some tests and I was unable to reproduce any problem when activating the Jetpack Extra Sidebar Widgets. The only non-default Comet Cache options that I thought might be related to this are 404 Request caching, GET Request caching, and the HTML Compressor (which also compresses JSON; see #469 and wpsharks/html-compressor#59). However, I wasn't able to reproduce any issue while testing with those features enabled. |
Thanks for additional details! :-) @jeherve writes...
@renzms Please try running this on an Apache server with Comet Cache 'Pro' Apache Optimizations enabled. See: Dashboard → Comet Cache Pro → Plugin Options → Apache Optimizations From that pane, note the setting for: Enforce Canonical URLs? That setting could be forcing a redirect that is incompatible with REST API endpoints.
Note the trailing slash was forced in that test. |
Comet Cache Pro zip file (latest bleeding edge) for developer testing: |
Adding here because this may be related. I had a site that has been incompatible with Jetpack since the 24th November, not that I noticed until my WP Stats vanished (Jeremy, this isn't the WPML site I contacted Jetpack support about last week -- different issue, different site). Attempts to reactivate WP Stats or many other Jetpack modules resulted in endpoint errors. To fix the issue I had to remove the Comet Cache directives from .htaccess, activate Jetpack modules then resave the Comet Cache settings. That's the only change to the site's configuration that resolved the issue. Before I edited .htaccess I tried (without good result),
Here are the Comet Cache directives I removed from .htaccess:
The above is identical to the new directives put into .htaccess when the Comet Cache options are resaved. The End Point errors occur whenever those rules are in .htaccess so the above solution is temp. Using Comet Cache Pro 161119 + Jetpack 4.4.1 The error displayed by Jetpack when attempts are made to reactive modules is: "JSON API failed to activate. Error: No route was found matching the URL and request method" |
@VR51 Thanks so much for that report! That just pinpointed the issue. As Jason suspected earlier, the Dashboard → Comet Cache Pro → Plugin Options → Apache Optimizations → Enforce Canonical URLs? is causing this problem. To reproduce the issue, I simply enabled that option in Comet Cache Pro, saved the Comet Cache settings, then tried to enable Extra Sidebar Widgets inside Jetpack: If I disable the Apache Optimizations Enforce Canonical URLs? in Comet Cache Pro and then attempt to enable the Jetpack Extra Sidebar Widgets again, it works: |
You are welcome! |
…sing default WP core globals for server detection, Comet Cache now uses it's own set of Apache/Nginx/IIS detection functions. And, this release enhances our Apache and Nginx detection routines; making them smart enough to catch additional edge cases; i.e., to further reduce the likelihood of there being a false-positive. See [Issue #748](wpsharks/comet-cache#748). - **Bug Fix:** Some Jetpack API calls were being cached inadvertently. See [Issue #855](wpsharks/comet-cache#855). - **Bug Fix:** Some XML-RPC and REST API requests were being cached inadvertently. See [Issue #855](wpsharks/comet-cache#855). - **Bug Fix:** Some REST requests were being redirected incorrectly whenever Apache Optimizations were enabled. See [Issue #855](wpsharks/comet-cache#855). - **Bug Fix:** Broken textarea field due to `white-space:nowrap` in Firefox. See [Issue #866](wpsharks/comet-cache#866). - **Enhancement:** Notes in HTML source now indicate fully functional on first load for improved clarity. See [Issue #860](wpsharks/comet-cache#860).
- **New Feature:** Comet Cache can now be configured to automatically clear the cache for date-based archive views whenever any single post is cleared due to changes in content, title, etc. See: **Dashboard → Comet Cache → Plugin Options → Automatic Cache Clearing → Auto-Clear "Date-Based Archives" Too?**. See also: [Issue #724](#724). - **New Pro Feature:** Apache Optimizations now include a new option that allows site owners to enforce an exact host name for all requests. See: **Dashboard → Comet Cache Pro → Plugin Options → Apache Optimizations → Enforce an Exact Host Name?**. See also: [Issue #101](#101). - **Bug Fix:** Apache detection sometimes inaccurate. So instead of using default WP core globals for server detection, Comet Cache now uses it's own set of Apache/Nginx/IIS detection functions. And, this release enhances our Apache and Nginx detection routines; making them smart enough to catch additional edge cases; i.e., to further reduce the likelihood of there being a false-positive. See [Issue #748](#748). - **Bug Fix:** Some XML-RPC and REST API requests were being cached inadvertently. See [Issue #855](#855). - **Bug Fix:** Broken textarea field due to `white-space:nowrap` in Firefox. See [Issue #866](#866). - **Bug Fix:** This release resolves empty directories being left in the cache folder, in some scenarios. See [Thread #866](https://forums.wpsharks.com/t/cache-folders-not-removed-during-clean-up-process/866). - **Bug Fix** (Pro): Some REST requests were being redirected incorrectly whenever Apache Optimizations were enabled. See [Issue #855](#855). - **Compatibility Bug Fix:** Some Jetpack API calls were being cached inadvertently. See [Issue #855](#855). - **Enhancement:** Notes in HTML source now indicate fully functional on first load for improved clarity. See [Issue #860](#860). - **Code Cleanup:** Enhancing security by removing `basename(__FILE__)` from direct access notices.
Noting that testing will be continued once issue with Apache detection,(#748) is resolved |
@raamdev @jaswsinc Fix Confirmed WorkingTested Using: WordPress Version: 4.7.2 Enabling: Dashboard → Comet Cache Pro → Plugin Options → Apache Optimizations → Enforce Canonical URLs? no longer causes an issue with enabling Jetpack's Continued testing for other Apache Optimizations and other options in Jetpack's panel, as well as testing with Network Site options. Both plugins are confirmed working. |
- **New Feature:** Comet Cache can now be configured to automatically clear the cache for date-based archive views whenever any single post is cleared due to changes in content, title, etc. See: **Dashboard → Comet Cache → Plugin Options → Automatic Cache Clearing → Auto-Clear "Date-Based Archives" Too?**. See also: [Issue #724](#724). - **New Pro Feature:** Apache Optimizations now include a new option that allows site owners to enforce an exact host name for all requests. See: **Dashboard → Comet Cache Pro → Plugin Options → Apache Optimizations → Enforce an Exact Host Name?**. See also: [Issue #101](#101). - **Bug Fix:** Apache detection sometimes inaccurate. So instead of using default WP core globals for server detection, Comet Cache now uses it's own set of Apache/Nginx/IIS detection functions. And, this release enhances our Apache and Nginx detection routines; making them smart enough to catch additional edge cases; i.e., to further reduce the likelihood of there being a false-positive. See [Issue #748](#748). - **Bug Fix:** Some XML-RPC and REST API requests were being cached inadvertently. See [Issue #855](#855). - **Bug Fix:** Broken textarea field due to `white-space:nowrap` in Firefox. See [Issue #866](#866). - **Bug Fix:** This release resolves empty directories being left in the cache folder, in some scenarios. See [Thread #866](https://forums.wpsharks.com/t/cache-folders-not-removed-during-clean-up-process/866). - **Bug Fix** (Pro): Some REST requests were being redirected incorrectly whenever Apache Optimizations were enabled. See [Issue #855](#855). - **Compatibility Bug Fix:** Some Jetpack API calls were being cached inadvertently. See [Issue #855](#855). - **Enhancement:** Notes in HTML source now indicate fully functional on first load for improved clarity. See [Issue #860](#860). - **Enhancement:** Enhancing security by removing `basename(__FILE__)` from direct access notices.
Comet Cache v170220 has been released and includes changes from this GitHub Issue. See the v170220 announcement for further details. This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#855). |
Referencing Comet Cache mentioned here:
https://wordpress.org/support/topic/extra-sidebar-widgets-not-working/#post-8493697
It seems there could be some WP REST API responses getting cached by Comet Cache and as a result, some Jetpack module activations are not possible when Comet Cache is running.
Further testing is required to confirm and identify the cause of this.
The text was updated successfully, but these errors were encountered: