Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Should redirect_to Override One-Time-Offers? #119

Closed
jaswrks opened this issue Apr 30, 2014 · 6 comments
Closed

Should redirect_to Override One-Time-Offers? #119

jaswrks opened this issue Apr 30, 2014 · 6 comments

Comments

@jaswrks
Copy link
Contributor

jaswrks commented Apr 30, 2014

A user writes...

Redirect to Previous Page. I noticed that will bypass any first-time-login page set in s2member. I hope you can improve upon this process. A user, just coming in to log in we would prefer going to account. Someone reading a blog post should be redirected back to the blog post I guess we have to accept one or the other. But my main concern is the bypassing of the first-time, fifth-time, etc logins.

@jaswrks
Copy link
Contributor Author

jaswrks commented May 27, 2014

@WebSharks/team Any thoughts on this?
Should redirect_to override everything? Including One-Time Offers Upon Login too?

2014-05-26_21-39-24

@raamdev
Copy link
Contributor

raamdev commented May 27, 2014

Should redirect_to override everything? Including One-Time Offers Upon Login too?

I would say yes. Here's why:

If I'm specifying a URL to redirect, I expect the user to get redirected straight there. I wouldn't want them to get interrupted by anything in between, even One-Time-Offers. In fact, when I read the "One-Time-Offers (Upon Login)" panel, it sounds to me like it applies only to those logins that will be arriving at the Login Welcome Page (i.e., without a custom redirect_to).

That said, I can see how this might get confusing for someone if they use the redirect_to and the One-Time-Offers... if users nearly always get to the login page by attempting to view protected content, as opposed to always logging in via the normal login box, then they'd never see the One-Time-Offers.

However, I still stand by my opinion that redirect_to should always override One-Time-Offers. A simple explanation of that fact should just be added to the One-Time-Offers option panel.

@jaswrks
Copy link
Contributor Author

jaswrks commented May 28, 2014

@raamdev I agree with you. The note in the Dashboard would be a good idea, thank you.

I'd love to find a way to make this better. I think the biggest issue is that the Pro Login Widget uses redirect_to quite extensively. So integrating that really causes some problems for One-Time Offers, since just about every login uses the redirect_to variable.

I'll give it some more thought. I was just thinking maybe there is a way for us to make an exception in some cases; where perhaps the redirect_to variable is being passed automatically by the Pro Login Widget, and it's just using a default value. Maybe another variable, like &redirect_to_automatic to signal this to the One-Time Offer system.

@raamdev
Copy link
Contributor

raamdev commented May 28, 2014

Maybe another variable, like &redirect_to_automatic to signal this to the One-Time Offer system.

That sounds like a good idea to me.

@jaswrks
Copy link
Contributor Author

jaswrks commented Jul 1, 2014

Moving this to the "Future Release" milestone.

@jaswrks jaswrks added this to the Future Release milestone Jul 1, 2014
@jaswrks jaswrks added pro and removed question labels Jul 1, 2014
@jaswrks jaswrks self-assigned this Aug 7, 2014
@jaswrks
Copy link
Contributor Author

jaswrks commented Aug 7, 2014

Assigning this to myself :octocat:

jaswrks pushed a commit to wpsharks/s2member-pro that referenced this issue Aug 7, 2014
jaswrks pushed a commit to wpsharks/s2member-pro that referenced this issue Aug 7, 2014
jaswrks pushed a commit that referenced this issue Aug 7, 2014
jaswrks pushed a commit that referenced this issue Aug 7, 2014
@jaswrks jaswrks closed this as completed Aug 7, 2014
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

3 participants