Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

QUICK_CACHE_ALLOWED set to a boolean-ish FALSE value #172

Closed
raamdev opened this issue May 27, 2014 · 6 comments
Closed

QUICK_CACHE_ALLOWED set to a boolean-ish FALSE value #172

raamdev opened this issue May 27, 2014 · 6 comments

Comments

@raamdev
Copy link
Contributor

raamdev commented May 27, 2014

For some reason, s2Member is setting the QUICK_CACHE_ALLOWED constant to a FALSE value when loading protected pages.

If I'm running Quick Cache with Logged-In User caching enabled (Dashboard → Quick Cache → Plugin Options → Logged-In Users set to "Yes, and maintain a separate cache") and one of my s2Member users visits a protected page, the following appears in the HTML notes:

screen shot 2014-05-26 at 8 36 28 pm

Is there actually a good reason or is this a bug?

Steps to reproduce

  1. Install Quick Cache Pro (v140104 simply shows nothing in the HTML notes, while v140520-RC shows the message in the screenshot above)
  2. Enable Logged-In User caching (Dashboard → Quick Cache → Plugin Options → Logged-In Users set to "Yes, and maintain a separate cache")
  3. Install s2Member Pro (v140520) and restrict a post on your site to Level 1
  4. Create a new user with Level 1 access
  5. Login to the site with user created in previous step
  6. Visit protected post and "view source"

Originally reported at wpsharks/comet-cache#174.

@jaswrks
Copy link
Contributor

jaswrks commented May 27, 2014

Thanks! It's the intended functionality. However, now that QC Pro allows for user caching I think there is room for improvement here in s2Member also. I'm not seeing any reason why s2Member could not allow protected pages to be cached for logged-in users.

I'm going to review this carefully before a change is made, but for now I agree with you. Looks like we'll need a new argument to this method in s2Member.

@jaswrks
Copy link
Contributor

jaswrks commented May 27, 2014

Hmm... I see that we may need to distinguish Quick Cache from other WP caching plugins too, before we allow this; since not all caching plugins would be compatible with a user-specific cache generation.

@jaswrks jaswrks added this to the Future Release milestone Jun 3, 2014
@jaswrks
Copy link
Contributor

jaswrks commented Jun 3, 2014

Moving this to the "Future Release" milestone.

@jaswrks
Copy link
Contributor

jaswrks commented Jun 9, 2014

Moving this to the "Next Release" milestone.

jaswrks pushed a commit to wpsharks/s2member-pro that referenced this issue Jun 14, 2014
jaswrks pushed a commit that referenced this issue Jun 14, 2014
#199 and #172
also works toward resolving #195
@jaswrks jaswrks closed this as completed Jun 14, 2014
@jaswrks
Copy link
Contributor

jaswrks commented Jun 14, 2014

This was resolved in the release of s2Member v140614
https://github.com/websharks/s2member/releases/tag/140614

@KTS915
Copy link

KTS915 commented Jun 15, 2014

This is great! Thanks very much!

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

3 participants