Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Import Google Font css #142

Closed
wei opened this issue Nov 9, 2022 · 2 comments · Fixed by #148 or #154
Closed

Import Google Font css #142

wei opened this issue Nov 9, 2022 · 2 comments · Fixed by #148 or #154
Assignees
@wei
Labels
enhancement New feature or request

Comments

@wei
Copy link
Owner

wei commented Nov 9, 2022 •
edited
Loading

google-fonts-plugin was removed with our dependency upgrade 434727f.

Let's look into a better way to import google font into the svg image.
@wei wei added the enhancement New feature or request label Nov 9, 2022
@wei
Copy link
Owner Author

wei commented Nov 12, 2022

This should probably be done as a part of #135. Example: https://vercel.com/docs/concepts/functions/edge-functions/og-image-examples#using-a-custom-font

@wei wei mentioned this issue Nov 12, 2022
Merged
4 tasks
@wei wei self-assigned this Nov 12, 2022
@wei
Copy link
Owner Author

wei commented Nov 16, 2022

Fonts will be imported dynamically during runtime from @fontsource over jsdelivr. This is because endpoints are packaged into edge functions which have a limit of 1MB total. Loading fonts dynamically will also give us the ability to add new fonts easily.

@wei wei mentioned this issue Nov 21, 2022
Merged
@wei wei closed this as completed in #154 Nov 21, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@wei wei

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨ Use satori for SVG generation wei/socialify
✨ Version 2.0 wei/socialify
1 participant
@wei