Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

FullScreen key assignment does nothing #177

Closed
wez opened this issue May 4, 2020 · 7 comments
Closed

FullScreen key assignment does nothing #177

wez opened this issue May 4, 2020 · 7 comments
Labels
bug Something isn't working Windows Issue applies to Microsoft Windows

Comments

@wez
Copy link
Member

wez commented May 4, 2020

This was a casualty of migrating away from the winit crate, and because I rarely use that functionality except on Linux where the window manager often has an equivalent function, I haven't gotten around to adding it back yet.

#172
@wez wez added the bug Something isn't working label May 4, 2020
@mfiers
Copy link

mfiers commented Aug 14, 2020

I'd much appreciate this ability to return.

@JoyceBabu JoyceBabu mentioned this issue Sep 27, 2020
Closed
wez added a commit that referenced this issue Dec 28, 2020
@wez
wezterm: plumbing for FullScreen action
7ae52cd 
Hooks up toggling fullscreen mode on macos, with plumbing for
other systems.

I prefer not to use the "modern fullscreen" mode because I find
the transition animations in macOS are horrendously slow.

I'll make an option to allow selecting whether that is used or not
in a follow-on diff.

refs: #177
wez added a commit that referenced this issue Dec 28, 2020
@wez
window+gui: macOS: add native_macos_fullscreen_mode option
d302f82 
Defaults to false.  If set to true, the ToggleFullScreen action
prefers native macOS fullscreen mode.

refs: #177
wez added a commit that referenced this issue Dec 28, 2020
@wez
window: implement FullScreen for x11
c68bf92 
refs: #177
wez added a commit that referenced this issue Jan 18, 2021
@wez
docs: note about fullscreen mode support
83dbf03 
refs: #177
@wez wez added the Windows Issue applies to Microsoft Windows label Feb 18, 2021
@wez
Copy link
Member Author

wez commented Feb 18, 2021

The current status is that this is now working everywhere except Windows

@wez wez closed this as completed in 38e6a1b Feb 27, 2021
@honeyspoon
Copy link

should I create another issue called "FullScreen key assignment does nothing on windows"?

@wez
Copy link
Member Author

wez commented Oct 4, 2021

38e6a1b made it work again on Windows, which is why this issue was closed.
If you're running version 20210314-114017-04b7cedd or later and it doesn't work, please file a new issue.

@dufferzafar
Copy link

@wez Is there a way I can start the terminal in full screen mode by default?

@wez
Copy link
Member Author

wez commented Nov 5, 2021

@dufferzafar: not yet, see #284

wez added a commit that referenced this issue Jul 7, 2022
@wez
add window:toggle_fullscreen()
dbc2c85 
You can start a window in full screen mode using something like:

```lua
local wezterm = require 'wezterm'

local mux = wezterm.mux

wezterm.on("gui-startup", function()
  local tab, pane, window = mux.spawn_window{}
  window:gui_window():toggle_fullscreen()
end)

return {
}
```

refs: #177
refs: #284
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
bug Something isn't working Windows Issue applies to Microsoft Windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mfiers @wez @dufferzafar @honeyspoon