Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Unable to scroll in less and most #429

Closed
MuhammedZakir opened this issue Jan 17, 2021 · 9 comments
Closed

Unable to scroll in less and most #429

MuhammedZakir opened this issue Jan 17, 2021 · 9 comments

Comments

@MuhammedZakir
Copy link
Contributor

MuhammedZakir commented Jan 17, 2021

I am unable to scroll in less and most, but I am able to do it in Vim. Is this is a bug, or is this not implemented?

P.S. I am using wezterm (20201101-103216-403d002d-235-gbd614b5e) on Manjaro (X11).

@wez
Copy link
Member

wez commented Jan 17, 2021

What do you mean by scroll? Please describe clearly what action you are taking, what you expect to happen, and what actually happened!

@wez
Copy link
Member

wez commented Jan 18, 2021

Someone also brought up scrolling over here: https://matrix.to/#/!RibfHDCcaAAcGCkNEM:gitter.im/$YuhdRuRpNhLLI7ZGDD-_ncP29M5Xf3IQvwyVe-h_puE?via=gitter.im&via=matrix.org

It looks like there's been a regression in the logic that maps the wheel to the cursor keys when the alt screen is active

wez added a commit that referenced this issue Jan 18, 2021
This appears to have been broken since the introduction of mouse
assignments :-/

This commit adds Pane::is_alt_screen_active so that the gui layer
can tell whether the alt screen is active, and allow passing down
the event.

refs: #429
@wez
Copy link
Member

wez commented Jan 18, 2021

I've pushed a commit that should show up in the nightly builds in the next hour or two

wez added a commit that referenced this issue Jan 18, 2021
@MuhammedZakir
Copy link
Contributor Author

MuhammedZakir commented Jan 18, 2021

Someone also brought up scrolling over here: https://matrix.to/#/!RibfHDCcaAAcGCkNEM:gitter.im/$YuhdRuRpNhLLI7ZGDD-_ncP29M5Xf3IQvwyVe-h_puE?via=gitter.im&via=matrix.org

It looks like there's been a regression in the logic that maps the wheel to the cursor keys when the alt screen is active

When I couldn't scroll, I checked wezterm doc to see if I need to enable any option for it work. Then I found this - "SGR style mouse reporting (works in vim and tmux)", in Features page. So I tested scrolling in Vim to see if it's working, and for me, scrolling in Vim was working. Probably because I have this in my config:

 if has('mouse_sgr')
  set ttymouse=sgr
endif
set mouse=vi

This made me confused over whether this works only if this "SGR" is supported. That's why, I asked whether scrolling in others is currently implemented/supported or not. I admit that I don't know anything about this.

Edit: I just found out scrolling in Vim is only working in wezterm nightly. It is not working in normal release. That's probably why it didn't work for that user in Matrix room.

Edit-2: I was wrong. See below.

@MuhammedZakir
Copy link
Contributor Author

MuhammedZakir commented Jan 18, 2021

I've pushed a commit that should show up in the nightly builds in the next hour or two

It's working now. But when compared to other terminals (e.g. Konsole, Yakuake), scrolling is slow. Is there anything I can do to increase scrolling speed?

@bew
Copy link
Member

bew commented Jan 18, 2021

I just found out scrolling in Vim is only working in wezterm nightly. It is not working in normal release.

I'm surprised you say that, I'm using neovim with the config set mouse=nv, and mouse scrolling and selection has always been working in wezterm normal releases

@MuhammedZakir
Copy link
Contributor Author

MuhammedZakir commented Jan 18, 2021

I just found out scrolling in Vim is only working in wezterm nightly. It is not working in normal release.

I'm surprised you say that, I'm using neovim with the config set mouse=nv, and mouse scrolling and selection has always been working in wezterm normal releases

That's weird. Are you using latest release? Because I was using nightly release, I had to install wezterm-bin AUR package for testing. So I am not sure why we are getting different results. Maybe I did something wrong? I will test this again and report back soon.

Edit: Silly me! 😬 When testing, I tried scrolling in normal mode whereas I only enabled mouse in insert and visual modes. Sorry!

@wez
Copy link
Member

wez commented Jan 18, 2021

Re: questions about scroll speed, I've opened #432 to track that as an enhancement request.

Let's close this since the original issue is resolved!

@wez wez closed this as completed Jan 18, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants