Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Provide reg keys for scoop installs to allow 'Open WezTerm here' #486

Closed
0xMOPI opened this issue Feb 14, 2021 · 3 comments
Closed

Provide reg keys for scoop installs to allow 'Open WezTerm here' #486

0xMOPI opened this issue Feb 14, 2021 · 3 comments
Labels
enhancement New feature or request PR-welcome Wez doesn't have plans to work on this, but will accept a PR if someone feels motivated! Windows Issue applies to Microsoft Windows

Comments

@0xMOPI
Copy link

0xMOPI commented Feb 14, 2021

Is your feature request related to a problem? Please describe.
Scoop installation doesn't allow for this to be added automatically

Describe the solution you'd like
Provide wezterm_install_context.reg and wezterm_uninstall_context.reg in the current directory that enable and disable the context menu entries, and make a note field in the wezterm.json alerting the user to it's existence

Additional context
The scoop-extras vscode already does this exact solution for their app

@0xMOPI 0xMOPI added the enhancement New feature or request label Feb 14, 2021
@wez wez added the Windows Issue applies to Microsoft Windows label Feb 17, 2021
@wez
Copy link
Owner

wez commented Feb 17, 2021

FWIW, I don't maintain the scoop side of this.

I'm open to a PR that would add those .reg files to the assets/windows directory if you'd like to contribute that.
Note that #451 is tracking an issue with one of those registry settings, and I haven't had time to sit down and debug it.

@wez wez added the PR-welcome Wez doesn't have plans to work on this, but will accept a PR if someone feels motivated! label Feb 17, 2021
@prabirshrestha
Copy link

Why not just make it as part of the cli? clink does something similar. Not sure if scoop would support it. I personally do prefer clink style but it does start increasing the scope of wezterm cli.

clink autorun install
wezterm install
wezterm install --user
wezterm install --open-wezterm-here --user
wezterm uninstall --open-wezterm-here --user
wezterm install --open-wezterm-here --user-all
wezterm uninstall --open-wezterm-here --user-all

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
enhancement New feature or request PR-welcome Wez doesn't have plans to work on this, but will accept a PR if someone feels motivated! Windows Issue applies to Microsoft Windows
Projects
None yet
Development

No branches or pull requests

3 participants