Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Invalid color scheme TOML silently ignored #794

Closed
sclu1034 opened this issue May 14, 2021 · 1 comment
Closed

Invalid color scheme TOML silently ignored #794

sclu1034 opened this issue May 14, 2021 · 1 comment
Labels
bug Something isn't working fixed-in-nightly This is (or is assumed to be) fixed in the nightly builds.

Comments

@sclu1034
Copy link

sclu1034 commented May 14, 2021

Describe the bug

When a color scheme defined as TOML file at ~/.config/wezterm/colors contains invalid data, it is treated as non-existent. Trying to use that color scheme only yields a Your configuration specifies color_scheme="Gruvbox Light Soft" but that scheme was not found.
Only when that color scheme definition is moved to Lua does WezTerm print the actual error in the color scheme.

Environment:

OS: Linux X11
Version: wezterm 20210511-192024-a59e9b17

To Reproduce

Create a color scheme with 9 elements in the ansi or brights lists and save it in ~/.config/wezterm/colors.
Then try to apply it with color_scheme = "<file_name>"

Expected behavior

WezTerm should

  • inform the user that the file does exist and where it was found, but that it contains invalid data
  • print the error that occurred while parsing/loading the color scheme. The same error that it does print when the color scheme is defined in Lua.
@sclu1034 sclu1034 added the bug Something isn't working label May 14, 2021
wez added a commit that referenced this issue May 15, 2021
@wez wez added the fixed-in-nightly This is (or is assumed to be) fixed in the nightly builds. label May 15, 2021
@wez wez closed this as completed May 22, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
bug Something isn't working fixed-in-nightly This is (or is assumed to be) fixed in the nightly builds.
Projects
None yet
Development

No branches or pull requests

2 participants