Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow styling of the whole new tab button #950

Merged
merged 1 commit into from
Jul 19, 2021

Conversation

sdrik
Copy link
Contributor

@sdrik sdrik commented Jul 17, 2021

Replace new_tab_left, new_tab_right, new_tab_hover_left and new_tab_hover_right elements in tab_bar_style with more flexible new_tab and new_tab_hover elements.
Also introduce new_tab and new_tab_hover elements in colors.tab_bar.

@sdrik sdrik force-pushed the style-whole-new-tab-button branch from ac2c888 to 06f7856 Compare July 17, 2021 16:09
Copy link
Member

@wez wez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@@ -1,5 +1,8 @@
# `tab_bar_style`

`new_tab_left`, `new_tab_right`, `new_tab_hover_left`, `new_tab_hover_right`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a since line here; when I cut a release, I will fill in the release identifier across the docs.

Suggested change
`new_tab_left`, `new_tab_right`, `new_tab_hover_left`, `new_tab_hover_right`
*Since: nightly builds only*
`new_tab_left`, `new_tab_right`, `new_tab_hover_left`, `new_tab_hover_right`

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change applied and force-pushed.

@sdrik sdrik force-pushed the style-whole-new-tab-button branch from 06f7856 to fd3db73 Compare July 18, 2021 08:43
@wez wez merged commit 77261ac into wezterm:main Jul 19, 2021
wez added a commit that referenced this pull request Jul 19, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants