Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Consider using the GitHub Checks API #241

Open
domenic opened this issue Oct 19, 2021 · 2 comments
Open

Consider using the GitHub Checks API #241

domenic opened this issue Oct 19, 2021 · 2 comments

Comments

@domenic
Copy link
Member

domenic commented Oct 19, 2021

https://docs.github.com/en/rest/reference/checks

This seems like it might be more suitable for PR-focused checks. Our current use of "commit statuses" leads to issues like #172.

I am aware of some other CLA-checker services making this switch currently.

@annevk
Copy link
Member

annevk commented Oct 20, 2021

I might be missing something, but is this not a problem?

Note: The Checks API only looks for pushes in the repository where the check suite or check run were created. Pushes to a branch in a forked repository are not detected and return an empty pull_requests array.

Or does it no longer solely count as a branch on a forked repository once a pull request is made?

@domenic
Copy link
Member Author

domenic commented Oct 20, 2021

Interesting. I think "it no longer solely count as a branch on a forked repository once a pull request is made" is the case in a technical sense, but that's always felt like an undocumented side effect of the GitHub infrastructure, and not something to rely on. I wonder what happens in practice.

It does seem like the API would be pretty useless if it didn't detect updates to PRs made from forks, so I suspect it works. But that wording is strange.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

No branches or pull requests

2 participants