Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Missing fingerprints on events #4

Open
dcramer opened this issue Dec 20, 2019 · 3 comments
Open

Missing fingerprints on events #4

dcramer opened this issue Dec 20, 2019 · 3 comments
Labels
question Further information is requested

Comments

@dcramer
Copy link

dcramer commented Dec 20, 2019

Might try to resolve this myself, but events right now aren't fingerprinted at all which means every node's unique error becomes a unique issue in Sentry, but what you really want is that every unique type of error is a unique issue (and every pod experiencing that error bubbles up to the same issue).

There's a few approaches to this, but the current sentry-kubernetes does this fairly well.

@dcramer
Copy link
Author

dcramer commented Dec 20, 2019

Example of an event from sentry-kubernetes: https://sentry.io/share/issue/be9e0777979344f3b76af9acffff9acc/

@dcramer
Copy link
Author

dcramer commented Dec 20, 2019

Also realizing this ticket is not correct - you are setting a fingerprint, but I would advise removing the node name from it. That would achieve what I'm looking for, and you'll find it makes Sentry a lot more powerful.

It, for example, allows you to create a breakdown of all nodes experiment out of memory issues.

@wichert
Copy link
Owner

wichert commented Mar 25, 2020

I don't actually include the node name in the fingerprint directly, so I'm wondering where that comes from.

@wichert wichert added the question Further information is requested label May 5, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants