Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Test workflow has some false-negatives #456

Open
philclifford opened this issue Aug 18, 2022 · 2 comments
Open

Test workflow has some false-negatives #456

philclifford opened this issue Aug 18, 2022 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@philclifford
Copy link
Member

philclifford commented Aug 18, 2022

The excellent testing workflow thanks to @OhMyMndy seems to have some "false negative" failures that need a tweak or two.

Now it may well be that there is a valid failure of #449 I'm unable to spot, which still fails today. (Edit: found and fixed, and replaced with #457 , which works but is ugly and less readable )

But trying to "fix" that over recent days I stumbled into a few types of apparent false-negative "failures" , including:

compare my testing ,mainor auth-github branches and e.g. this revised multi-OS workflow for some of the head-banging and some possible fixes for some of the above,

Getting to #457 also suggests that it would be wise to ./deb-get clean >/dev/null before the test installs (or in the prior stanza) to be sure to start them with a cleared cache

@philclifford
Copy link
Member Author

Also: should install tests be run if only README or other Documentation is touched? Maybe another workflow for docs or just limit jobs by file(s)

@OhMyMndy
Copy link
Contributor

Makes completely sense to increase the counter when it is up-to-date, didn't think about it when implementing that...

In bin-get I made sure that before running an installation (in the tests), the program isn't installed, but that wouldn't have worked out in this case.

@flexiondotorg flexiondotorg added the help wanted Extra attention is needed label Sep 23, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants