Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

It should be configurable to hide Hierachy on failure. #1113

Closed
reneeichhorn opened this issue Jan 9, 2019 · 1 comment
Closed

It should be configurable to hide Hierachy on failure. #1113

reneeichhorn opened this issue Jan 9, 2019 · 1 comment

Comments

@reneeichhorn
Copy link

Description

Larger apps especially apps that have tab navigations have a big amount of views / components.
In these cases printing the hierachy on error is not helpful at all and just causes endless scrolling in the terminal.

Steps to Reproduce

  • Run mid to large sized app
  • Cause any test to fail
  • Check terminal output.

Detox, Node, Device, Xcode and macOS Versions

  • Detox: 9.1.2
  • React Native: 0.57.4 (not related)
  • Node: 11.6.0 (happens on any)
  • Device: iPad Air Simulator (happens on any)
  • Xcode: 10.1 (not related)
  • macOS: Mojave (not related)
@LeoNatan
Copy link
Contributor

Hello,

This has been asked in the past and we have declined. I don't think we will reconsider at this point, sorry.

The size of app does not dictate that its view hierarchy be unmanageable or unreadable. On a general note, unrelated to Detox, if your view hierarchy is huge, you should consider improving your app. Huge view hierarchies slow down the app and give a bad user experience. In the case of React Native, even more care has to be put when building apps. If you are using JS navigation solutions, you can move to a proper solution that does not require that all views of all tabs be present on screen. That makes no sense.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 16, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants