Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

device.relaunchApp was supposedly removed as of Detox 6, but still is defined #1217

Closed
solkaz opened this issue Mar 20, 2019 · 2 comments
Closed

device.relaunchApp was supposedly removed as of Detox 6, but still is defined #1217

solkaz opened this issue Mar 20, 2019 · 2 comments
Labels
domain: documentation status: accepted status: discussion

Comments

@solkaz
Copy link
Contributor

solkaz commented Mar 20, 2019

Per the docs for device, relaunchApp was deprecated and supposed to have been removed as of Detox 6, but it is still defined
@solkaz
Copy link
Contributor Author

solkaz commented Mar 20, 2019 •
edited
Loading

There are still some docs that reference relaunchApp as well

@LeoNatan
Copy link
Contributor

Hello,

It has not been removed because we do not wish to break existing users. Since the function does nothing but call launchApp, there is little maintenance upkeep to keeping it.
I remove the line from documentation that it will be removed. It remains deprecated, however.

If you'd like, please submit a PR with removing relaunchApp from the docs and test suite. It would be greatly appreciated.

Thanks

@lock lock bot locked as resolved and limited conversation to collaborators Mar 24, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
domain: documentation status: accepted status: discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@LeoNatan @d4vidi @solkaz