Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Detox should allow us to set configuration outside package.json #758

Closed
Mokto opened this issue May 30, 2018 · 2 comments
Closed

Detox should allow us to set configuration outside package.json #758

Mokto opened this issue May 30, 2018 · 2 comments

Comments

@Mokto
Copy link

Mokto commented May 30, 2018

Description

Hi, it would be nice to configure detox outside package.json.

I get a Cannot read property 'configurations' of undefined when removing the configuration from package.json.

The reason behind this is that I have a lot of configurations, running them via a matrix Travis job.

Detox, Node, Device, Xcode and macOS Versions

  • Detox: 7.3.7
  • React Native: 0.55.4
  • Node: 8
  • Device: /
  • Xcode: 9.3
  • macOS: 10.13

Thanks !

@Mokto Mokto changed the title Allows to set detox configuration outside package.json Detox should allow us to set configuration outside package.json May 30, 2018
@stale
Copy link

stale bot commented Jul 14, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest Detox and report back.
Thank you for your contributions.

@LeoNatan
Copy link
Contributor

LeoNatan commented Jul 14, 2018

One workaround is to sed or echo into the package.json and change it according to your CI environment. We do this in our own test project. See here: https://github.com/wix/detox/blob/master/scripts/change_react_native_version.js

This is not planned at this point.

@wix wix locked and limited conversation to collaborators Jul 23, 2018
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants