Skip to content
This repository was archived by the owner on Mar 16, 2019. It is now read-only.

Error compiling since 0.9.2 #97

Closed
Kaishley opened this issue Aug 24, 2016 · 5 comments
Closed

Error compiling since 0.9.2 #97

Kaishley opened this issue Aug 24, 2016 · 5 comments

Comments

@Kaishley
Copy link
Contributor

Kaishley commented Aug 24, 2016

Hi,

I just updated to 0.9.2 and I am having the following error when compiling.

android\src\main\java\com\RNFetchBlob\RNFetchBlobBody.java:107: error: method contentLength() is already defined in class RNFetchBlobBody public long contentLength() { ^ Note: Some input files use or override a deprecated API.

There's duplicated code in the RNFetchBlobBody.java at lines 97 and 107

@wkh237
Copy link
Owner

wkh237 commented Aug 24, 2016

Hi @Kaishley , thanks for reporting this issue. I think this only happens on react-native < 0.27 since the older OkHttp does not support overriding contentLength method.

The reason why we override contentLength is addressed in #94 , therefore I think to fix this problem by change prelink script is a much preferable way 👍

@Kaishley
Copy link
Contributor Author

Hi @wkh237
The problem is there is duplicate code of the override. Please check lines 97 and 107 :)

@wkh237
Copy link
Owner

wkh237 commented Aug 24, 2016

Okay, @Kaishley I see the duplicated code there, I'll merge the PR, thank you 😄

@wkh237
Copy link
Owner

wkh237 commented Aug 24, 2016

@Kaishley , a new version 0.9.3 is published to npm, please try to install the updated package, feel free file an issue if there's any problem, thank you 😏

@Kaishley
Copy link
Contributor Author

@wkh237 Cheers ;)

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

No branches or pull requests

2 participants