fixed some issues, shortened html/java code

- reverting name to `linked_remote`
- ESPNow remote list is now hidden if unchecked
- shortened java script function names and variables to save flash
- removed now obsolete settings in xml.cpp
- correct checking of valid hex string for remote list in java script

Author: DedeHai

wled00/cfg.cpp

@@ -39,7 +39,7 @@ bool deserializeConfig(JsonObject doc, bool fromFS) {
 #ifndef WLED_DISABLE_ESPNOW
   CJSON(enableESPNow, nw[F("espnow")]);
   linked_remotes.clear();
-  JsonArray lrem = nw[F("lrem")]; // array of MAC addresses
+  JsonArray lrem = nw[F("linked_remote")]; // array of MAC addresses
   if (!lrem.isNull()) {
     for (size_t i = 0; i < lrem.size(); i++) {
       std::array<char, 13> entry{};
@@ -739,7 +739,7 @@ void serializeConfig(JsonObject root) {
   JsonObject nw = root.createNestedObject("nw");
 #ifndef WLED_DISABLE_ESPNOW
   nw[F("espnow")] = enableESPNow;
-  JsonArray lrem = nw.createNestedArray(F("lrem"));
+  JsonArray lrem = nw.createNestedArray(F("linked_remote"));
   for (size_t i = 0; i < linked_remotes.size(); i++) {
     lrem.add(linked_remotes[i].data());
   }

wled00/data/settings_wifi.htm

@@ -136,68 +136,75 @@
 			getLoc();
 			loadJS(getURL('/settings/s.js?p=1'), false);	// If we set async false, file is loaded and executed, then next statement is processed
 			if (loc) d.Sf.action = getURL('/settings/wifi');
+      setTimeout(tE, 500); // wait for DOM to load before calling tE()
 		}
 
-    var remoteCount = 0;
-    // Initialize empty list for remotes
-    function resetRemotes() {
-      d.getElementById('rmlist').innerHTML = '';
-      remoteCount = 0;
-      updateRMArray();
+    var rC = 0; // remote count
+    // toggle visibility of ESP-NOW remote list based on checkbox state
+    function tE() {
+      const e = d.querySelector('input[name="RE"]').checked;
+      const l = gId('rlc');  // remote list container
+      // keep the hidden input with MAC addresses, only toggle visibility of the list UI
+      if (l) l.style.display = e ? 'block' : 'none';
     }
-
-    // Add a Remote MAC to the list
-    function addRemote(id, mac) {
-      if (!mac || mac === 'None') return;
-      if (remoteCount >= 10) return;
-      let inputs = d.getElementById('rmlist').getElementsByTagName('input');
+    // reset remotes: initialize empty list (called from xml.cpp)
+    function rstR() {
+      gId('rml').innerHTML = ''; // clear remote list
+      rC = 0;
+      uR(); // update remote list
+    }
+    // add remote MAC to the list
+    function aR(id, mac) {
+      if (!/^[0-9A-F]{12}$/i.test(mac)) return; // check for valid hex string
+      if (rC >= 10) return;
+      let inputs = gId('rml').getElementsByTagName('input');
       for (let i = 0; i < inputs.length; i++) {
         if (inputs[i].value === mac) return;
       }
-      let list = d.getElementById('rmlist');
-      let row = d.createElement('div');
-      let inp = d.createElement('input');
+      let list = gId('rml');
+      let row = cE('div');
+      let inp = cE('input');
       inp.type = 'text';
       inp.name = id;
       inp.value = mac;
       inp.maxLength = 12;
       inp.minLength = 12;
-      inp.onchange = updateRMArray;
+      inp.onchange = uR;
       row.appendChild(inp);
       let btn = d.createElement('button');
       btn.type = 'button';
       btn.className = 'btn btn-xs';
       btn.innerText = 'Remove';
       btn.onclick = function() {
-        removeRemote(row);
+        rR(row);
       };
       row.appendChild(btn);
       list.appendChild(row);
-      remoteCount++;
-      updateRMArray();
+      rC++;
+      uR();
     }
-    // Remove a remote from the list
-    function removeRemote(element) {
-      element.remove();
-      updateRMArray();
+    // remove a remote from the list
+    function rR(e) {
+      e.remove();
+      uR();
     }
-    // Update hidden input with JSON array of MACs
-    function updateRMArray() {
+    // update remote list
+    function uR() {
       let macs = [];
-      let inputs = d.getElementById('rmlist').getElementsByTagName('input');
+      let inputs = gId('rml').getElementsByTagName('input');
       for (let i = 0; i < inputs.length; i++) {
         if (inputs[i].value && inputs[i].value !== '') {
           macs.push(inputs[i].value);
         }
       }
-      d.getElementById('rmacs').value = JSON.stringify(macs);
+      gId('rmacs').value = JSON.stringify(macs);
       return true; // Allow form submission to continue
     }
 	</script>
 	<style>@import url("style.css");</style>
 </head>
 <body onload="S()">
-  <form id="form_s" name="Sf" method="post" onsubmit="return updateRMArray()">
+  <form id="form_s" name="Sf" method="post" onsubmit="return uR()">
 		<div class="toprow">
 		<div class="helpB"><button type="button" onclick="H('features/settings/#wifi-settings')">?</button></div>
 		<button type="button" onclick="B()">Back</button><button type="submit">Save & Connect</button><hr>
@@ -258,13 +265,15 @@ <h3>ESP-NOW Wireless</h3>
 			<i class="warn">This firmware build does not include ESP-NOW support.<br></i>
 		</div>
 		<div id="ESPNOW">
-			Enable ESP-NOW: <input type="checkbox" name="RE"><br>
+      Enable ESP-NOW: <input type="checkbox" name="RE" onchange="tE()"><br>
 			<i>Listen for events over ESP-NOW<br>
 			Keep disabled if not using a remote or wireless sync, increases power consumption.<br></i>
-      Last device seen: <span class="rlid">None</span>
-      <button type="button" class="btn btn-xs" onclick="addRemote('RM'+remoteCount,this.parentElement.querySelector('.rlid').textContent)">Add</button><br>
-      Linked MACs:<br>
-      <div id="rmlist">
+      <div id="rlc">
+        Last device seen: <span class="rlid" id="ld">None</span>
+        <button type="button" class="btn btn-xs" onclick="aR('RM'+rC,gId('ld').textContent)">Add</button><br>
+        Linked MACs:<br>
+        <div id="rml">
+        </div>
       </div>
       <input type="hidden" name="RMA" id="rmacs">
 		</div>

wled00/xml.cpp

@@ -216,9 +216,9 @@ void getSettingsJS(byte subPage, Print& settingsScript)
 
     #ifndef WLED_DISABLE_ESPNOW
     printSetFormCheckbox(settingsScript,PSTR("RE"),enableESPNow);
-    settingsScript.printf_P(PSTR("resetRemotes();"));
+    settingsScript.printf_P(PSTR("rstR();")); // reset remote list
     for (size_t i = 0; i < linked_remotes.size(); i++) {
-      settingsScript.printf_P(PSTR("addRemote(\"RM%u\",\"%s\");"), i, linked_remotes[i].data());
+      settingsScript.printf_P(PSTR("aR(\"RM%u\",\"%s\");"), i, linked_remotes[i].data()); // add remote to list
     }
     #else
     //hide remote settings if not compiled
@@ -261,10 +261,6 @@ void getSettingsJS(byte subPage, Print& settingsScript)
     #ifndef WLED_DISABLE_ESPNOW
     if (strlen(last_signal_src) > 0) { //Have seen an ESP-NOW Remote
       printSetClassElementHTML(settingsScript,PSTR("rlid"),0,last_signal_src);
-    } else if (!enableESPNow) {
-      printSetClassElementHTML(settingsScript,PSTR("rlid"),0,(char*)F("(Enable ESP-NOW to listen)"));
-    } else {
-      printSetClassElementHTML(settingsScript,PSTR("rlid"),0,(char*)F("None"));
     }
     #endif
   }