Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Please export wsApplication #3

Open
BryanHunt opened this issue Sep 18, 2022 · 3 comments
Open

Please export wsApplication #3

BryanHunt opened this issue Sep 18, 2022 · 3 comments

Comments

@BryanHunt
Copy link

It would be very helpful if wsApplication were exported so I can use it as a type in my code without having to import it as:

import { wsApplication } from '@wll8/express-ws/dist/type.js';
@wll8
Copy link
Owner

wll8 commented Sep 18, 2022

Sorry I don't quite understand what you mean.
It looks like it's already exported, either in index.ts#L70 or in type.ts#L42.

Or you can try to make a PR?

@BryanHunt
Copy link
Author

Here is the error I get ...

Screen Shot 2022-09-19 at 9 53 00 AM

@wll8
Copy link
Owner

wll8 commented Sep 19, 2022

It looks like only this line of code can be used:

import { wsApplication } from '@wll8/express-ws/dist/type'

Because @wll8/express-ws exports a function by default, not an object.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants