Should return http.Response for paste?

[chandru89new]

In this code:

        hb, hr, err := p.hibp.HTTPResBody(http.MethodGet, apiURL, nil)
	if err != nil {
		return nil, nil, err
	}

the http response is ignored and nil returned if there is any error. However, the error might come from the API call, in which case there could be a response and should be passed down this method as well. Is nil being returned intentionally?

[wneessen]

Good catch. Thanks for the report. That's definitely an oversight and not intended. I'll fix that tomorrow and create a new release.

[chandru89new]

Hi @wneessen thanks for the quick fix. The issue exists in breach, password APIs as well (sorry I just noticed it).

[wneessen]

Yeah, I am already working on the breaches fix as well, but wanted to keep it as a separate commit. In fact I am currently overhauling the whole error handling a bit. All coming commits will be put together in the next release.

[wneessen]

Version 1.0.5 has just been released with the corresponding fixes.
https://github.com/wneessen/go-hibp/releases/tag/v1.0.5

[chandru89new]

Great work, @wneessen. We use your SDK at Steampipe and I'd like to thank you on behalf of the whole team for the SDK and the great work you've put in.

[wneessen]

Appreciate it!