Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

No error message for non-existant commits #37

Open
MohammadEglil opened this issue Oct 6, 2022 · 4 comments
Open

No error message for non-existant commits #37

MohammadEglil opened this issue Oct 6, 2022 · 4 comments
Assignees

Comments

@MohammadEglil
Copy link

I used to get error messages when I would execute the command echo <commit> | ~/lookup/getValues c2dat for a commit which does not exist. But now I just get nothing as an output whereas I used to get no map for c2dat some time ago

@audrism
Copy link
Collaborator

audrism commented Oct 17, 2022

showCnt gives errors while getValues does not when fed sha1 for an object that is not in the database.
Perhaps this should be an option for both.

@loconous
Copy link
Collaborator

loconous commented Jun 1, 2023

Opened PR for change on error message for getValues.
See PR here: https://bitbucket.org/swsc/lookup/pull-requests/7

@loconous
Copy link
Collaborator

loconous commented Jun 1, 2023

This PR is merged. @MohammadEglil please verify and resolve issue at your convenience. Thanks!

@loconous
Copy link
Collaborator

@MohammadEglil have you been able to verify if this fixed your issue? If so, please resolve at your convenience.
Also, as an FYI, see #45. This would allow to suppress this messages with a flag, but it is currently not implemented.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants